Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE] Argentine confederation rework #156

Open
wants to merge 1,530 commits into
base: master
Choose a base branch
from

Conversation

anzu-3278
Copy link
Collaborator

No description provided.

@@ -21,6 +21,7 @@
has_country_flag = Alberdi
}
war = no
is_ideology_enabled = anarcho_liberal
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be removed, An-Lib is active from gamestart now

@@ -105,6 +106,7 @@
tag = LPL
}
year = 1844
is_ideology_enabled = anarcho_liberal
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above

}
}

# #Description: Urquiza's Statement - issue a statement of independence if Rosas doesn't step down
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this intentionally disabled?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ARG content was intentionally disabled until the ARC rework is finished

@@ -205,24 +205,6 @@
religion = orthodox
size = 1025
}

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these hungarians going poof intentionally?

#Tripoli-Libya(600000)
#Tripolitania Region (335000)
#Tripoli (75000/30000 POPS)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indentation needs fixing

@@ -19,7 +19,6 @@
religion = sunni
size = 175
}

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these empty lines removed intentionally? Otherwise restore

@@ -1170,6 +1170,13 @@
last_names = { Alfaro Andueza Arboleda Blanco Bonnet Boyd Caama�o Carre�o Carri�n Castro Chiari Cordero Crespo Daza "de Herrera" "de Mosquera" "de Obald�a" "de Olmedo" "de Veintemilla" "de Villamil" Falc�n Flores Garc�a G�mez Gonz�lez Gual Guti�rrez Herr�n Hurtado L�pez Mallarino Manjarr�s Mari�o Melo Monagas Moreno N��ez Obando P�ez Porras Reyes Robles Rocafuerte Rojas Salgar Santander Soublette Urbina Villegas Zald�a }
}

# Spanish Gaucho #
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file needs to be brought in line with main cultures.txt

y = 4
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this intentional?

@@ -15,6 +15,8 @@

# French literacy low compared to HFM

# Multiple issues with Switzerland partition related to different Italy tags
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many issues that were since fixed have returned here, remove them

@@ -893,22 +949,20 @@ VNZ_ADJ;Venezuelan;V
VOC_ADJ;Compagnie;;;;;;;;;;;;;x
VOC_colonial_company_ADJ;Dutch;;;;;;;;;;;;;x
VOJ_ADJ;Vojvodinian;;;;;;;;;;;;;x
VOJ_colonial_company_ADJ;Serbian Frontiersman;;;;;;;;;;;;;x
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are these going poof?

WES_ADJ;Westphalian;;;;;;;;;;;;;x
WHA_ADJ;Welsh;;;;;;;;;;;;;x
WIA_ADJ;Vientiane;;;;;;;;;;;;;x
WIN_ADJ;Windward Islander;;;;;;;;;;;;;x
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this one removed intentionally?

@ColdSlav ColdSlav self-assigned this Jan 14, 2023
@ColdSlav ColdSlav added Enhancement New feature or request Content This is related to flavor and mechanics of Victoria II labels Jan 14, 2023
@ColdSlav ColdSlav added Help Wanted Extra attention is needed and removed N/A This will not be worked on labels Apr 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content This is related to flavor and mechanics of Victoria II Enhancement New feature or request Help Wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants