Reverted non needed changes - kept casts correction part only

The-Cataclysm-Preservation-Project · Oct 30, 2023 · f19ed6f · f19ed6f
1 parent 04cb9f6
commit f19ed6f
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 8 deletions.
diff --git a/src/server/game/Handlers/GroupHandler.cpp b/src/server/game/Handlers/GroupHandler.cpp
@@ -51,7 +51,8 @@ class Aura;
 
 void WorldSession::SendPartyResult(PartyOperation operation, const std::string& member, PartyResult res, uint32 val /* = 0 */)
 {
-    WorldPackets::Party::PartyCommandResult packet(member);
+    WorldPackets::Party::PartyCommandResult packet;
+    packet.Name = member;
     packet.Command = static_cast<uint32>(operation);
     packet.Result = static_cast<uint32>(res);
     packet.ResultData = val;

diff --git a/src/server/game/Server/Packets/PartyPackets.h b/src/server/game/Server/Packets/PartyPackets.h
@@ -106,17 +106,15 @@ namespace WorldPackets
         class PartyCommandResult final : public ServerPacket
         {
         public:
-            PartyCommandResult(std::string const& _name) : ServerPacket(SMSG_PARTY_COMMAND_RESULT, 4 + _name.length() + 4 + 4 + 8),
-                Command(0), Result(0), ResultData(0), Name(_name) { }
+            PartyCommandResult() : ServerPacket(SMSG_PARTY_COMMAND_RESULT, 4 + 1 + 4 + 4 + 8) { }
 
             WorldPacket const* Write() override;
 
-            uint32 Command;
-            uint32 Result;
-            uint32 ResultData;
-            ObjectGuid ResultGUID;
-        private:
             std::string Name;
+            uint32 Command = 0;
+            uint32 Result = 0;
+            uint32 ResultData = 0;
+            ObjectGuid ResultGUID;
         };
 
         class PartyInviteClient final : public ClientPacket