fix: revive theme using semantic tags and aria attributes for selectors (WIP) #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unfortunately, I couldn't figure out a way to get the 'Buttons in settings now uses accent color' styles working well with this, as there isn't really a way I can see to select only the smaller buttons or to select the larger buttons (to revert the styles on those)
This makes use of the semantic HTML tags
…viewing older messages styles
Again, semantic tags, along with role attributes
use message selector as parent and have all the styles contained as children
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes use of the changes in revoltchat/revite#415 to be able to create specific enough selectors without much trouble and not have to rely on unpredictable class names.
This is still incomplete, and revoltchat/revite#415 is still a draft, so obviously this is a draft as well.
I disabled _typing.css because one of the classes in there (
.cs-dacGJm) happened to by very slim chance clash with the channel description class when running revite locally.