Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated styles to align buttons and gifs containers #8

Merged
merged 1 commit into from
Feb 28, 2021

Conversation

devautor
Copy link
Contributor

I am working with two and three columns layout and the defaults works beautifully. Have updated a few of the styles with EDIT markers in corresponding comments in order to fix:

  • input box should fill whole space, after placing provider logo
  • type buttons should not be stretched vertically
  • horizontal margin should be present between buttons only, and not on their end-sides
  • there should be no right margin for last image column

P.S. Thanks again for creating and working on this library ::)

I am working with two and three columns layout and the defaults works beautifully. Have updated a few of the styles with *EDIT* markers in corresponding comments in order to fix:
- input box should fill whole space, after placing provider logo
- type buttons should not be stretched vertically
- horizontal margin should be present between buttons only, and not on their end-sides
- there should be no right margin for last image column
@Thanasis1101 Thanasis1101 merged commit fe9b242 into Thanasis1101:master Feb 28, 2021
@Thanasis1101
Copy link
Owner

Thanasis1101 commented Feb 28, 2021

@devautor The fixes are now public in version 1.2.1 !
I saw your changes and fixed a couple things:

  • When there were no numOfColumns (horizontal view), there were no right margins for any gif. So I added a check for horizontal or not.
  • I found the width:'25%' very small so I changed it to a default of 35% and I added the property providerLogoStyle so that you can set it like this providerLogoStyle={{width:'40%'}}

I also gave you credits in the Version History section of the README.md.

I am glad that you find the package useful and thank you very much for helping improve it !

@Thanasis1101 Thanasis1101 self-requested a review February 28, 2021 17:38
@Thanasis1101 Thanasis1101 added the gui A fix on the Graphical User Interface label Feb 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gui A fix on the Graphical User Interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants