Fix build with OPENSSL_NO_DEPRECATED #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Creating and verifying RSA signatures requires some OpenSSL functions declared in the `openssl/rsa.h` header. When `OPENSSL_NO_DEPRECATED` is not defined this header gets indirectly included. But with this define set the function declarations are missing. This commit adds an explicit include for the file to fix this.
Some functions from OpenSSL redefined in `OpenSSLErrorTest.cpp` use types that are not available when `OPENSSL_NO_DEPRECATED` is defined. Since they do not seem to be actually used this commit simply removes them.
1 task
prince-chrismc
approved these changes
May 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add missing include to fix build with
OPENSSL_NO_DEPRECATEDdefined and adjust the deprecation test to set this define. Also remove some unused re-definitions of OpenSSL functions inOpenSSLErrorTest.cppthat use types that are not defined withOPENSSL_NO_DEPRECATED.Fixes #223.