Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added id and label key generators #22

Closed
wants to merge 1 commit into from
Closed

Added id and label key generators #22

wants to merge 1 commit into from

Conversation

bernard-wagner
Copy link
Contributor

Partially implements #15

Copy link
Contributor

@nickrmc83 nickrmc83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bernard-wagner can you add or update appropriate test cases to exercise the new public API functions?

@dmjones
Copy link
Contributor

dmjones commented Jan 15, 2019

Hi @bernard-wagner. Thank you for taking the time to share your pull request.

As you may have just seen in #15, the future of key generation in the library is in question. If you would like to join that discussion, please do. Unless we change our minds on that point, I can't see us merging this particular PR.

@bernard-wagner
Copy link
Contributor Author

bernard-wagner commented Feb 13, 2019

@bernard-wagner can you add or update appropriate test cases to exercise the new public API functions?

Any guidance on how to structure these tests without duplicating all the existing tests, as the same code paths will be covered 99% of the time?

@dmjones
Copy link
Contributor

dmjones commented Feb 14, 2019

Closing this PR, per my comment above (#22 (comment)).

@dmjones dmjones closed this Feb 14, 2019
@dmjones dmjones removed bug labels Mar 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants