Skip to content

Commit

Permalink
fix for deadlock
Browse files Browse the repository at this point in the history
  • Loading branch information
willmcgugan committed Dec 2, 2021
1 parent eff8da6 commit 40dbc0a
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 3 deletions.
6 changes: 6 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,12 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [10.15.2] - 2021-12-02

This comment has been minimized.

Copy link
@glensc

glensc Dec 3, 2021

Contributor

missing reflink again


### Fixed

- Deadlock issue https://github.com/willmcgugan/rich/issues/1734

## [10.15.1] - 2021-11-29

### Fixed
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
name = "rich"
homepage = "https://github.com/willmcgugan/rich"
documentation = "https://rich.readthedocs.io/en/latest/"
version = "10.15.0"
version = "10.15.2"
description = "Render rich text, tables, progress bars, syntax highlighting, markdown and more to the terminal"
authors = ["Will McGugan <[email protected]>"]
license = "MIT"
Expand Down
3 changes: 1 addition & 2 deletions rich/live.py
Original file line number Diff line number Diff line change
Expand Up @@ -128,11 +128,11 @@ def stop(self) -> None:
with self._lock:
if not self._started:
return
self.console.clear_live()
self._started = False

if self.auto_refresh and self._refresh_thread is not None:
self._refresh_thread.stop()
self._refresh_thread.join()
self._refresh_thread = None
# allow it to fully render on the last even if overflow
self.vertical_overflow = "visible"
Expand All @@ -158,7 +158,6 @@ def stop(self) -> None:
# jupyter last refresh must occur after console pop render hook
# i am not sure why this is needed
self.refresh()
self.console.clear_live()

def __enter__(self) -> "Live":
self.start(refresh=self._renderable is not None)
Expand Down

0 comments on commit 40dbc0a

Please sign in to comment.