Update dependencies, include 64bit arch #37
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 |
Closed
|
squidpunch duplicated this pull request on my fork of Frank. I merged his changes with mine and then fixed a couple of issues where his work was not complete. I generated a new pull request #40 for the combination of squidpunch's work and my work, so you could take just that one instead of this one. |
|
This got resolved independently by PR #42 |
|
closing, looks like @CMTaylor pulled in my changes to a new PR that was merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This may only be an issue when using frank in Ruby Motion, but when I attempt to run my frank features with the latest version of RubyMotion the skeleton doesnt get included because the 64-bit arch isnt included. I think this is a guard clause since apps will require 64-bit architecture to be included starting in Feb 2015.
In any event this makes it possible for me to use frank again on my project, so I'd like to see it merged if it isnt a breaking change for other users, etc.