Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use GCC_PREPROCESSOR_DEFINITIONS #23

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

use GCC_PREPROCESSOR_DEFINITIONS #23

wants to merge 1 commit into from

Conversation

jberkel
Copy link
Contributor

@jberkel jberkel commented May 21, 2014

the problem with GCC_PREPROCESSOR_DEFINITIONS_NOT_USED_IN_PRECOMPS is
that it is causing compilation errors when compiling the project with
-Werror / -Weverything (unused macro warning)

the problem with GCC_PREPROCESSOR_DEFINITIONS_NOT_USED_IN_PRECOMPS is
that it is causing compilation errors when compiling the project with
`-Werror` / `-Weverything` (unused macro warning)
@MichaelBuckley
Copy link
Contributor

I'm sympathetic to wanting to use -Werror and -Weverything, but I don't think this will fix the problem in all cases. Are you using the FRANKIFIED macro in your precompiled header? For users who don't use the FRANKIFIED macro at all, I think they'll still get an error.

And in general, we don't want to use GCC_PREPROCESSOR_DEFINITIONS, because we don't want to insert symbols into the project's precompiled header.

@MichaelBuckley
Copy link
Contributor

I'm not sure there's a good solution to this problem except to use the FRANKFIED macro somewhere if you have -Werror and -Weverything turned on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants