Add better error messages for selector matchers #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I like it. |
MichaelBuckley
added a commit
that referenced
this pull request
Jan 19, 2014
…ctor-matchers Add better error messages for selector matchers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds better error messages to the be_true and be_false rspec matchers in the element exists Frank helpers.
I've been increasingly calling the frank helpers directly from my page models rather than using the built in cucumber steps, and I wasn't getting any useful error messages when elements didn't match, just true != false which doesn't give much context. I tried to add more useful messages that would say whether an element was found or not, and what the selector was.