Fix ZLC format #85
Merged
Fix ZLC format #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-test runs. this is necessary for the second STARTS run to build on top of the first STARTS run, otherwise both runs will be fresh.
This reverts commit 10461be
Was getting error on Java 9+: java.lang.ClassCastException: class [Ljava.lang.Object; cannot be cast to class [Ljava.lang.String; ([Ljava.lang.Object; and [Ljava.lang.String; are in module java.base of loader 'bootstrap')
On Windows, STARTS get non-affected test paths with backward-slash separator. Surefire only accept excludes with forward-slash. So all tests were executed previously. Replacing the file separator to forward slash to exclude correct tests.
|
@owolabileg Please review. Those fixes should better be in separate PRs, but most of them were discovered while I was trying to fix the ZLC format. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cloneCleanto false so the integration tests can test starts on modified code, thanks to @cptwontonmvn cleanon AppVeyor and Travis, since the integration tests won't auto overwrite now.toArray()returnsObject[]andtoArray(new String[])returnsString[].