Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add it and report coverage #72

Merged
merged 15 commits into from
May 27, 2021
Merged

Add it and report coverage #72

merged 15 commits into from
May 27, 2021

Conversation

jtx1999
Copy link
Contributor

@jtx1999 jtx1999 commented May 24, 2021

Add integration tests.
Add Github action to report coverage on PRs.

@owolabileg
Copy link
Collaborator

Check the exact tests affected

Has this been fixed @jtx1999 ?

@owolabileg
Copy link
Collaborator

Check the exact tests affected

What about this one, @jtx1999 ??

@jtx1999
Copy link
Contributor Author

jtx1999 commented May 25, 2021

Check the exact tests affected

What about this one, @jtx1999 ??

@owolabileg Not yet, I'm going to add that

@owolabileg
Copy link
Collaborator

@jtx1999 what is the status of this PR? Is there a plan to fix the failing build?

@jtx1999
Copy link
Contributor Author

jtx1999 commented May 27, 2021

@jtx1999 what is the status of this PR? Is there a plan to fix the failing build?

@owolabileg
The checks for the exact tests are added.
The Github action for adding comments doesn't work on non-collaborators due to permission issues.
The failed maven builds were possibly due to Github outage, will retry soon.

@jtx1999
Copy link
Contributor Author

jtx1999 commented May 27, 2021

@owolabileg Please review

@owolabileg
Copy link
Collaborator

owolabileg commented May 27, 2021 •
edited
Loading

The Github action for adding comments doesn't work on non-collaborators due to permission

@jtx1999 so, what does the current PR do for coverage instead? Can we add a coverage badge to the README?

@jtx1999
Copy link
Contributor Author

jtx1999 commented May 27, 2021

@jtx1999 so, what does the current PR do for coverage instead? Can we add a coverage badge to the README?

@owolabileg The current PR logs the coverage to stdout in the actions run, e.g. https://github.com/TestingResearchIllinois/starts/pull/72/checks?check_run_id=2687294098
Screen Shot 2021-05-27 at 2 48 45 PM

Can we merge this PR first? I'll add a coverage badge later.

@owolabileg owolabileg mentioned this pull request May 27, 2021
Closed
@owolabileg owolabileg merged commit 215203a into TestingResearchIllinois:master May 27, 2021
@owolabileg
Copy link
Collaborator

@jtx1999 see #81

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jtx1999 @owolabileg