adding functionality for retesting all when the classpath changes #13

milicahtanovic · 2017-09-19T00:58:21Z

august782 · 2017-09-19T01:05:51Z

starts-core/src/main/java/edu/illinois/starts/helpers/Writer.java

+                    continue;
+                }
+                String mapping = getJarToChecksumMapping(jarsList[i]);
+                writer.write(mapping + "\n");


Use System.lineSeparator() instead of \n

august782 · 2017-09-19T01:07:18Z

starts-core/src/main/java/edu/illinois/starts/helpers/Writer.java

+            InputStream is = Files.newInputStream(Paths.get(jar));
+            DigestInputStream dis = new DigestInputStream(is, md);
+            while (dis.read(bytes) != -1) {
+                ;


What's with the empty loop? Is it purposely empty? It might look better without the brackets and just the semicolon.

It's not empty technically, it is filling the 'bytes' array.
I used 'while (dis.read(bytes) != -1);' but checkstyle complained, it requires {}.

it is filling and then overwritting right? If the loop executes more than once you only get the last 8192 bytes and loose the prior ones, which may or may not be what you want.

I understand. We are going to fix it and the whole algorithm in fact.

It is fixed now.

august782 · 2017-09-19T01:09:35Z

starts-core/src/main/java/edu/illinois/starts/helpers/Writer.java

+
+            byte[] mdbytes = md.digest();
+            for (int i = 0; i < mdbytes.length; i++) {
+                sb.append(Integer.toString((mdbytes[i] & 0xff) + 0x100 , 16).substring(1));


What is the goal of this math with hex values when making the String? Some comment could help.

Yes, I added the description now. It is computing the checksum of the jars.

This is changed to use commons-codec to get hex.

august782 · 2017-09-19T01:10:46Z

starts-core/src/main/java/edu/illinois/starts/helpers/Writer.java

+        } catch (NoSuchAlgorithmException nsae) {
+            nsae.printStackTrace();
+        }
+        return jar + "," + sb.toString();


If you're already using a StringBuilder, just use the StringBuilder to concatenate the Strings, instead of using the + (which will make a new StringBuilder anyway).

Also, in case of exceptions happening, the StringBuilder could be empty, right? Will this be accounted for later?

Ok, fixed it.
Yes, it could be empty and it would just write an empty line. Now I added a condition to skip if it could not generate the checksum.

august782 · 2017-09-19T01:17:20Z

starts-plugin/src/main/java/edu/illinois/starts/jdeps/RunMojo.java

+            if (sb.length() == 0) {
+                sb.append(paths[i]);
+            } else {
+                sb.append(":" + paths[i]);


If you're already using a StringBuilder, it's best to just use the StringBuilder methods to concatenate Strings instead of using +.

I agree, done.

To explain why these comments keep coming up, read this: http://www.pellegrino.link/2015/08/22/string-concatenation-with-java-8.html
It's a performance hit if you concatenate a lot of stuff... probably you don't but it's good to write good code.

august782 · 2017-09-19T01:18:13Z

starts-plugin/src/main/java/edu/illinois/starts/jdeps/RunMojo.java

+    private String cleanClassPath(String cp) {
+        String[] paths = cp.split(":");
+        StringBuilder sb = new StringBuilder();
+        for (int i = 0; i < paths.length; i++) {


Is it ever possible for the paths to be in a different order? Is it necessary to sort first as to make the String always deterministic?

Good point. I will do set intersection instead?

If you are already putting them in sets just check for equality with equals()

august782 · 2017-09-19T01:19:02Z

starts-plugin/src/main/java/edu/illinois/starts/jdeps/RunMojo.java

+            if (!sfPathString.equals(cleanOldSfPathFileName)) {
+                return false;
+            }
+        } catch (IOException ioe) {


So upon IOException the return is true, meaning the classpaths would be considered the same. Is this what should happen?

I changed it to return true in the try block and false otherwise.

august782 · 2017-09-19T01:19:42Z

starts-plugin/src/main/java/edu/illinois/starts/jdeps/RunMojo.java

@@ -101,4 +114,58 @@ protected void setChangedAndNonaffected() throws MojoExecutionException {
        nonAffectedTests = data == null ? new HashSet<String>() : data.getKey();
        changedClasses  = data == null ? new HashSet<String>() : data.getValue();
    }
+
+    private boolean compareClassPaths(String sfPathString) throws MojoExecutionException {


Maybe change the name to instead of compareClassPaths to be something like checkIfSameClassPath, just to get the feel that the method returns a boolean.

Changed it.

august782 · 2017-09-19T01:20:21Z

starts-plugin/src/main/java/edu/illinois/starts/jdeps/RunMojo.java

+        return true;
+    }
+
+    private boolean checkJarChecksums(String cleanSfClassPath) throws MojoExecutionException {


Similar comment about name as for compareClassPaths.

Updated that too.

august782 · 2017-09-19T01:22:36Z

starts-plugin/src/main/java/edu/illinois/starts/jdeps/RunMojo.java

+                    return false;
+                }
+            }
+        } catch (IOException ioe) {


Similar comment concerning exception and return as in compareClassPaths.

Ok, added a flag to know if the exception happened and return false in that case.

Another thing with these exceptions is that they will happen on the first run always. We may want to silence them in that case?

check for file existence before the try:

if (!new File(oldChecksumPathFileName).exists()) { return false; }

Added the condition.

alexgyori

You should decide if portability is a concern, and if it is, you should clean it up to make it more portable.
You could also set it up to run tests on AppVeyor and you'd find probably a whole bunch of these issues.

alexgyori · 2017-09-19T03:25:51Z

starts-core/src/main/java/edu/illinois/starts/helpers/Writer.java

@@ -72,6 +77,22 @@ public static void writeClassPath(String sfPathString, String artifactsDir) {
        }
    }

+    public static void writeJarChecksums(String sfPathString, String artifactsDir) {
+        String outFilename = artifactsDir + File.separator + "jar-checksums";


It's safer to not concatenate paths this way (e.g., artifactsDir may or may not end with a File.separator already). There is a method Paths.get(...).

We are using Paths.get(...) later in the code for this exact string.

ok... but is there a reason to not use it here?

That would require to overload the method to which this string is passed and we don't want to do that.

I think it would still be good to use Paths.get(...), for same reasons as in other places with this pattern.

Yes, but as I said in this case it requires changing a method that is widely used within the whole project. This string gets passed to Paths.get(...) anyways.

I don't quite understand what widely used method is being changed here. Is it not enough to just change artifactDir + File.separator + "jar-checksum" to Paths.get(artifactDir, "jar-checksum").toString()?

alexgyori · 2017-09-19T03:29:56Z

starts-core/src/main/java/edu/illinois/starts/helpers/Writer.java

+    public static void writeJarChecksums(String sfPathString, String artifactsDir) {
+        String outFilename = artifactsDir + File.separator + "jar-checksums";
+        try (BufferedWriter writer = getWriter(outFilename)) {
+            String[] jarsList = sfPathString.split(":");


In unix systems the path separator is : but in windows it is ; (semicolon). To be portable use File.pathSeparator which gives you the right thing. As a rule of thumb, whenever you find yourself using some string literal ask if that's portable. If you set it yourself, it's fine; if it comes from the platform, check.

Not done here.

Ok, didn't see that. Changed it now.

alexgyori · 2017-09-19T03:30:49Z

starts-core/src/main/java/edu/illinois/starts/helpers/Writer.java

+        String outFilename = artifactsDir + File.separator + "jar-checksums";
+        try (BufferedWriter writer = getWriter(outFilename)) {
+            String[] jarsList = sfPathString.split(":");
+            for (int i = 0; i < jarsList.length; i++) {


You could use an enhanced for loop here to be more java-ic (is that the equivalent of pythonic?).

True, but it will eventually be broken down to this so it's not that important.

alexgyori · 2017-09-19T03:32:50Z

starts-core/src/main/java/edu/illinois/starts/helpers/Writer.java

+            InputStream is = Files.newInputStream(Paths.get(jar));
+            DigestInputStream dis = new DigestInputStream(is, md);
+            while (dis.read(bytes) != -1) {
+                ;


it is filling and then overwritting right? If the loop executes more than once you only get the last 8192 bytes and loose the prior ones, which may or may not be what you want.

alexgyori · 2017-09-19T03:35:11Z

starts-plugin/src/main/java/edu/illinois/starts/jdeps/RunMojo.java

+                String[] elems = line.split(",");
+                checksumMap.put(elems[0], elems[1]);
+            }
+            String[] jars = cleanSfClassPath.split(":");


use pathSeparator if needed...

Ok, changed it.

alexgyori · 2017-09-19T03:35:53Z

starts-plugin/src/main/java/edu/illinois/starts/jdeps/RunMojo.java

+    private String cleanClassPath(String cp) {
+        String[] paths = cp.split(":");
+        StringBuilder sb = new StringBuilder();
+        for (int i = 0; i < paths.length; i++) {


enhanced for loop to be more java-ic.

alexgyori · 2017-09-19T03:36:16Z

starts-plugin/src/main/java/edu/illinois/starts/jdeps/RunMojo.java

+        String[] paths = cp.split(":");
+        StringBuilder sb = new StringBuilder();
+        for (int i = 0; i < paths.length; i++) {
+            if (paths[i].contains("/target/classes") || paths[i].contains("/target/test-classes")


this is definitely not portable; in windows you'd have \.

alexgyori · 2017-09-19T03:36:31Z

starts-plugin/src/main/java/edu/illinois/starts/jdeps/RunMojo.java

+        StringBuilder sb = new StringBuilder();
+        for (int i = 0; i < paths.length; i++) {
+            if (paths[i].contains("/target/classes") || paths[i].contains("/target/test-classes")
+                || paths[i].contains("-SNAPSHOT.jar")) {


endsWith instead of contains maybe?

Yes, I will consider that.

alexgyori · 2017-09-19T03:38:46Z

starts-plugin/src/main/java/edu/illinois/starts/jdeps/RunMojo.java

+            if (sb.length() == 0) {
+                sb.append(paths[i]);
+            } else {
+                sb.append(":" + paths[i]);


To explain why these comments keep coming up, read this: http://www.pellegrino.link/2015/08/22/string-concatenation-with-java-8.html
It's a performance hit if you concatenate a lot of stuff... probably you don't but it's good to write good code.

alexgyori · 2017-09-19T03:39:17Z

starts-plugin/src/main/java/edu/illinois/starts/jdeps/RunMojo.java

+            if (sb.length() == 0) {
+                sb.append(paths[i]);
+            } else {
+                sb.append(":" + paths[i]);


Do you want to use pathSeparator here to be portable? i.e., it's : on unix and ; on windows?

alexgyori · 2017-09-20T04:47:10Z

starts-core/src/main/java/edu/illinois/starts/helpers/Writer.java

@@ -72,6 +77,22 @@ public static void writeClassPath(String sfPathString, String artifactsDir) {
        }
    }

+    public static void writeJarChecksums(String sfPathString, String artifactsDir) {
+        String outFilename = artifactsDir + File.separator + "jar-checksums";


ok... but is there a reason to not use it here?

alexgyori · 2017-09-20T04:47:28Z

starts-core/src/main/java/edu/illinois/starts/helpers/Writer.java

+    public static void writeJarChecksums(String sfPathString, String artifactsDir) {
+        String outFilename = artifactsDir + File.separator + "jar-checksums";
+        try (BufferedWriter writer = getWriter(outFilename)) {
+            String[] jarsList = sfPathString.split(":");


Not done here.

alexgyori · 2017-09-20T04:48:25Z

starts-core/src/main/java/edu/illinois/starts/helpers/Writer.java

+                if (mapping.split(",").length < 2) {
+                    continue;
+                }
+                writer.write(mapping + System.lineSeparator());


have two calls to write rather than concatenate (which creates a new StringBuilder...)

alexgyori · 2017-09-20T04:51:24Z

starts-plugin/src/main/java/edu/illinois/starts/jdeps/RunMojo.java

@@ -101,4 +114,69 @@ protected void setChangedAndNonaffected() throws MojoExecutionException {
        nonAffectedTests = data == null ? new HashSet<String>() : data.getKey();
        changedClasses  = data == null ? new HashSet<String>() : data.getValue();
    }
+
+    private boolean checkIfSameClassPath(String sfPathString) throws MojoExecutionException {
+        String oldSfPathFileName = getArtifactsDir() + "sf-classpath";


similarly here you are assuming that the path returned by the getArtifactsDir ends with / or . If it doesn't this path is incorrect. Use Paths.get(...) maybe.

I just added File.separator.

I think what Alex is saying is that you would never be sure that getArtifactsDir() actually returns a String that ends with File.separator; later somebody could change it, or someone reading this code would never be sure that it ends with File.separator (and would need to jump 2 or 3 files just to double-check, which I did...). Just to be safe, it would be good to explicitly use something like Paths.get(...). As of now, it does indeed work though, since getArtifactsDir() does end with File.separator.

Fixed in the newer version.

alexgyori · 2017-09-20T04:55:39Z

starts-plugin/src/main/java/edu/illinois/starts/jdeps/RunMojo.java

+        String[] paths = cp.split(File.pathSeparator);
+        StringBuilder sb = new StringBuilder();
+        for (int i = 0; i < paths.length; i++) {
+            if (paths[i].contains("/target/classes") || paths[i].contains("/target/test-classes")


These paths don't quite work on Windows.

Ok, I used the File.separator-s here too.

owolabileg · 2017-11-06T15:07:46Z

@august782 @denizarsan @alexgyori I'd like to merge this ASAP. Please take one final look.

august782 · 2017-11-06T18:25:03Z

starts-plugin/src/main/java/edu/illinois/starts/jdeps/RunMojo.java

@@ -117,12 +117,14 @@ protected void setChangedAndNonaffected() throws MojoExecutionException {

    private boolean checkIfSameClassPath(String sfPathString) throws MojoExecutionException {
        String oldSfPathFileName = getArtifactsDir() + "sf-classpath";
-        Set<String> sfClassPathSet = new HashSet<>(Arrays.asList(sfPathString.split(":")));
+        Set<String> sfClassPathSet = new HashSet<>(Arrays.asList(sfPathString.split(File.pathSeparator)));
+        if (!new File(oldSfPathFileName).exists()) {


Maybe move this conditional check one line earlier, before setting sfClassPathSet, as if it does not exist, making that Set is not necessary.

august782 · 2017-11-06T18:25:38Z

starts-plugin/src/main/java/edu/illinois/starts/jdeps/RunMojo.java

+        Set<String> sfClassPathSet = new HashSet<>(Arrays.asList(sfPathString.split(File.pathSeparator)));
+        if (!new File(oldSfPathFileName).exists()) {
+            return false;
+        }
        try {
            String cleanOldSfPathFileName = cleanClassPath(Files.readAllLines(Paths.get(oldSfPathFileName)).get(0));
            Set<String> oldSfClassPathSet = new HashSet<>(Arrays.asList(cleanOldSfPathFileName.split(":")));


Same comment as before about : versus File.pathSeparator.

Already fixed.

august782 · 2017-11-06T18:26:20Z

starts-plugin/src/main/java/edu/illinois/starts/jdeps/RunMojo.java

@@ -135,13 +137,16 @@ private boolean checkIfSameJarChecksums(String cleanSfClassPath) throws MojoExec
        String oldChecksumPathFileName = getArtifactsDir() + "jar-checksums";
        Map<String, String> checksumMap = new HashMap<>();
        boolean noException = true;
+        if (!new File(oldChecksumPathFileName).exists()) {


Same comment as before, moving conditional closer to where it should be checked to exit earlier.

august782 · 2017-11-06T18:49:27Z

starts-plugin/src/main/java/edu/illinois/starts/jdeps/RunMojo.java

@@ -101,4 +114,69 @@ protected void setChangedAndNonaffected() throws MojoExecutionException {
        nonAffectedTests = data == null ? new HashSet<String>() : data.getKey();
        changedClasses  = data == null ? new HashSet<String>() : data.getValue();
    }
+
+    private boolean checkIfSameClassPath(String sfPathString) throws MojoExecutionException {
+        String oldSfPathFileName = Paths.get(getArtifactsDir() + File.separator + "sf-classpath");


If you are using Paths.get(...), you then don't need to append File.separator, you can just use Paths.get(getArtifactsDir(), "sf-classpath"), with the parts as arguments.

Yeah, I wasn't gonna include this in the commit. I am not sure I want to use Path.get(...). I just need a string here. I will remove Path.get(...).

You will actually need to put .toString() at the end to make it work for the String. I would still recommend it since Paths.get(...) has the logic for determining whether or not to use the File.separator when connecting the parts, leading to a cleaner String.

august782 · 2017-11-06T18:50:45Z

starts-plugin/src/main/java/edu/illinois/starts/jdeps/RunMojo.java

+            String cleanOldSfPathFileName = cleanClassPath(Files.readAllLines(Paths.get(oldSfPathFileName)).get(0));
+            Set<String> sfClassPathSet = new HashSet<>(Arrays.asList(sfPathString.split(File.pathSeparator)));
+            Set<String> oldSfClassPathSet = new HashSet<>(Arrays.asList(cleanOldSfPathFileName.split(File.pathSeparator)));
+            if (oldSfClassPathSet.equals(oldSfClassPathSet)) {


This is checking if oldSfClassPathSet is equal to itself. I believe you need it to be some other variable?

Oh I fix that on the other branch. Good catch.

denizarsan · 2017-11-06T18:51:22Z

starts-core/src/main/java/edu/illinois/starts/helpers/Writer.java

+                    continue;
+                }
+                String mapping = getJarToChecksumMapping(jarsList[i]);
+                if (mapping.split(",").length < 2) {


Where does "2" come from?

This is how I save them when I write to the file -> jar,checksum.

Can you add a comment explaining this? It will make things easier for others or for you in the future.

denizarsan · 2017-11-06T18:51:27Z

starts-core/src/main/java/edu/illinois/starts/helpers/Writer.java

+    public static String getJarToChecksumMapping(String jar) {
+        StringBuilder sb = new StringBuilder();
+        sb.append(jar);
+        sb.append(",");


You can chain these two appends for readability.

By chaining, do you mean something like sb.append(jar + ",")? I would actually not recommend that, since underneath that would create a new StringBuilder just to concatenate the two Strings, and since we already have a StringBuilder going it is a bit unoptimal.

No. I mean sb.append(jar).append(“,”).

denizarsan · 2017-11-06T18:51:33Z

starts-plugin/src/main/java/edu/illinois/starts/jdeps/RunMojo.java

@@ -101,4 +114,69 @@ protected void setChangedAndNonaffected() throws MojoExecutionException {
        nonAffectedTests = data == null ? new HashSet<String>() : data.getKey();
        changedClasses  = data == null ? new HashSet<String>() : data.getValue();
    }
+
+    private boolean checkIfSameClassPath(String sfPathString) throws MojoExecutionException {


What do you think about naming this "isSameClassPath" instead?

Sounds good.

denizarsan · 2017-11-06T18:51:36Z

starts-plugin/src/main/java/edu/illinois/starts/jdeps/RunMojo.java

+        return false;
+    }
+
+    private boolean checkIfSameJarChecksums(String cleanSfClassPath) throws MojoExecutionException {


Same as before: "hasSameJarChecksum"

denizarsan · 2017-11-06T18:51:40Z

starts-plugin/src/main/java/edu/illinois/starts/jdeps/RunMojo.java

+        return noException;
+    }
+
+    private String cleanClassPath(String cp) {


Same: "getCleanClassPath"

denizarsan · 2017-11-06T18:51:43Z

starts-plugin/src/main/java/edu/illinois/starts/jdeps/RunMojo.java

+        for (int i = 0; i < paths.length; i++) {
+            if (paths[i].contains(File.separator + "target" +  File.separator + "classes")
+                || paths[i].contains(File.separator + "target" + File.separator + "test-classes")
+                || paths[i].contains("-SNAPSHOT.jar")) {


contains -> endsWith

Yeah, I considered that but I don't think it makes much difference.

denizarsan · 2017-11-06T18:51:45Z

starts-plugin/src/main/java/edu/illinois/starts/jdeps/RunMojo.java

+                sb.append(paths[i]);
+            } else {
+                sb.append(File.pathSeparator);
+                sb.append(paths[i]);


You can chain these two appends for readability.

Same comment about comment about chaining from before.

Same reply: I mean sb.append(foo).append(bar). Sorry if it wasn’t clear.

august782 · 2017-11-06T18:52:58Z

starts-plugin/src/main/java/edu/illinois/starts/jdeps/RunMojo.java

+        String[] paths = cp.split(File.pathSeparator);
+        StringBuilder sb = new StringBuilder();
+        for (int i = 0; i < paths.length; i++) {
+            if (paths[i].contains(File.separator + "target" +  File.separator + "classes")


Small optimization, it may be good to create the one String that represents File.separator + "target" + ... outside the loop, so there is no String concatenation on every iteration of the loop.

august782 · 2017-11-06T19:07:35Z

starts-plugin/src/main/java/edu/illinois/starts/jdeps/RunMojo.java

+    }
+
+    private boolean checkIfSameJarChecksums(String cleanSfClassPath) throws MojoExecutionException {
+        String oldChecksumPathFileName = getArtifactsDir() + File.separator + "jar-checksums";


Same comment concerning using Paths.get(...).

I taught that the problem was the path separator?
What is the actual suggestion?

The suggestion is to do "String oldChecksumPathFileName = Paths.get(getArtifactsDir(), "jar-checksums").toString();"
The reason is because it is unclear (without spending some time looking) whether or not getArtifactsDir() has the File.separator at the end or not. If it does, it leads to a kind of ugly String with the double /. While this might not break functionality, it is usually better to use some utility methods that provide the benefit of the checking.

what happens if you have: "/home/milicah/" + File.separator + "something"?
You will have two /, i.e., //, in the middle of the string. Which may or may not break things depending on what you do. The first string may or may not have / at the end, you either put an assertion that ensures the first string doesn't end with /, or use Paths.get everywhere which has the logic to handle all these edge cases which we come up with because we actually ran into them.

I actually had that at some point. It didn't brake anything, but yeah it could.
I changed this to use Paths.get(...).

milicahtanovic · 2017-11-06T23:05:21Z

@alexgyori @august782 @denizarsan @owolabileg All the comments have been addressed, I think this branch is ready to merge.

denizarsan · 2017-11-06T23:09:23Z

@milicahtanovic You have some conflicts. Please resolve them before merging.

august782 · 2017-11-06T23:10:44Z

I don't think all comments have been addressed yet. Please at least make sure you have responded to each comment and answer any questions or acknowledge the comment.

milicahtanovic · 2017-11-06T23:19:36Z

Oh, I didn't see them. For some reason they didn't show up on the discussion board. I will go over this, sorry.

august782 · 2017-11-07T00:57:00Z

Please confirm on some small examples that the functionality is still working, that our suggestions did not break anything; try modifying the classpath and JARs on the classpath to test. After that, I believe it should be ready to merge.

milicahtanovic · 2017-11-07T04:20:28Z

I tested with changing the dependency versions and it behaves as expected.

adding functionality for retesting all when the classpath changes

60cebae

august782 reviewed Sep 19, 2017

View reviewed changes

alexgyori requested changes Sep 19, 2017

View reviewed changes

milicah2 added 2 commits September 18, 2017 22:59

PR comments addressed

68945c9

PR comments addressed, mainly portability issues

2b27384

alexgyori reviewed Sep 20, 2017

View reviewed changes

milicah2 and others added 3 commits September 20, 2017 18:17

missed separators at some places

d6fb575

writing twice instead of concating two strings

f068735

fixed hashing algorithm

8c8935c

owolabileg requested a review from denizarsan November 6, 2017 15:07

august782 reviewed Nov 6, 2017

View reviewed changes

addressed set creation issues

26487b9

august782 reviewed Nov 6, 2017

View reviewed changes

denizarsan reviewed Nov 6, 2017

View reviewed changes

august782 reviewed Nov 6, 2017

View reviewed changes

all comments addressed, ready for merge

e3a1664

Milica Hadzi-Tanovic and others added 5 commits November 6, 2017 17:45

all comments addressed hopefully

1ad2fd9

Merge branch 'master' into pom-retestall

9b23e3d

Merge branch 'master' into pom-retestall

39187df

paths.get problem fixed

9fa4158

done.

fe682b4

minor changes

e183c16

owolabileg merged commit b1864ca into TestingResearchIllinois:master Nov 7, 2017

This was referenced Nov 7, 2017

improve triggering of retestAll due to classpath changes #22

Open

deal with snapshot bug for triggering retestAll when classpath changes #23

Closed

use Paths.get() more uniformly #25

Open

owolabileg mentioned this pull request Dec 5, 2017

RunMojo throws IOException when retestAll is false #43

Closed

adding functionality for retesting all when the classpath changes #13

adding functionality for retesting all when the classpath changes #13

Conversation

milicahtanovic commented Sep 19, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

august782 Sep 19, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

august782 Sep 19, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

milicahtanovic Sep 19, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

alexgyori left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

alexgyori Sep 19, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

owolabileg commented Nov 6, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

august782 Sep 19, 2017 •

edited

Loading

august782 Sep 19, 2017 •

edited

Loading

milicahtanovic Sep 19, 2017 •

edited

Loading

alexgyori Sep 19, 2017 •

edited

Loading