Add new Accepted tests in hertzbeat #1149
Conversation
format_checker/forked-projects.json
Outdated
| @@ -467,4 +468,4 @@ | |||
| "https://github.com/zeroturnaround/gradle-jrebel-plugin": "unforked", | |||
| "https://github.com/zhangxd1989/spring-boot-cloud": "unforked", | |||
| "https://github.com/zhurlik/gradle-jboss-modules-plugin": "unforked" | |||
| } | |||
There was a problem hiding this comment.
What editor/IDE are you using to get this change automatically? At some point we may accept that change to stop dealing with unnecessary changes.
There was a problem hiding this comment.
I usually use vs code but for this change I directly made in GitHub by editing the file
There was a problem hiding this comment.
Can you test on another file if the GitHub editor automatically removes or adds newline at the end of the file?
There was a problem hiding this comment.
I edited another file requirements.txt. I just removed 1 and added 1 in the last line. That line is shown in the diff despite being exactly same.
There was a problem hiding this comment.
The line is not the same if it's in the diff. Can you search online about reports of GitHub editor adding/removing the newline character? Can that behavior be customized?
There was a problem hiding this comment.
I searched online and in github settings, but did not find any setting to control new lines in the github web editor. But there are options to manage these configurations at IDE level like in VS code. Also, there is an option in GitHub to edit a file in github.dev which opens the repo in an online vs code editor.
There was a problem hiding this comment.
I think that the GitHub editor is adding a new line at the end if the file doesn't have one
There was a problem hiding this comment.
In this PR, I was not able to reproduce the exact diff in new branches, I may have inadvertantly changed some space
There was a problem hiding this comment.
I found https://stackoverflow.com/questions/68088682/how-do-i-stop-githubs-web-editor-from-adding-a-newline-to-the-end-of-file but didn't test anything.
Please remove unnecessary changes so I can accept your PR.
There was a problem hiding this comment.
Removed unnecessary changes
|
Please squash commits. |
bbelide2
force-pushed
the
hertz
branch
3 times, most recently
from
6b757a4 to
1d5ea7e
Compare
Squashed all the commits and merged new changes |
|
I still see 2 commits. |
|
I squashed all the commits into one. |
|
@zzjas can you please double check? Things looked fine to me, but the PR is so big that it's good to have two reviewers. |
I added only 2 tests, but the diff is showing all the changes done by commits in between as well. I am not sure why but when I tried to squash, I am getting all the changes made by other people in between as well. Should I close this PR and open a new fresh PR instead? |
|
No, please don't close; you'll get -2 "points" for that. Just learn how to properly rebase your work and squash your commits. Please ask on Campuswire if you need help. |
I tried to do that but I am getting 2 commits - one squashed commit and one merge commit. This way I am only getting my changes. I did that now. I am having 2 commits including a merge commit. |
|
Thanks for cleaning this even while your laptop is broken! |
Adding 2 new Accepted tests in hertzbeat.
Both the tests are ID: details and logs are present in #1148
Root cause and fix details are present in the PRs:
apache/hertzbeat#1373
apache/hertzbeat#1371