feat!: allow disposing event registration and use globbing #707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vbreuss
added
enhancement
👽 Mutation ResultsTestably.Abstractions.TestingDetails
The final mutation score is 20.27%Coverage Thresholds: high:80 low:60 break:0Testably.Abstractions.AccessControlDetails
The final mutation score is NaN%Coverage Thresholds: high:80 low:60 break:0Testably.Abstractions.CompressionDetails
The final mutation score is NaN%Coverage Thresholds: high:80 low:60 break:0Testably.AbstractionsDetails
The final mutation score is NaN%Coverage Thresholds: high:80 low:60 break:0 |
Test Results 46 files ± 0 46 suites ±0 22m 14s ⏱️ -11s Results for commit dd9b9be. ± Comparison against base commit 3c033dd. This pull request removes 47552 and adds 47602 tests. Note that renamed tests count towards both.This pull request removes 2351 skipped tests and adds 2351 skipped tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
vbreuss
force-pushed
the
topic/allow-dispose-event-registration
branch
from
639f41d to
8ac7323
Compare
vbreuss
force-pushed
the
topic/allow-dispose-event-registration
branch
from
2821bff to
dd9b9be
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the return type for event registration to an
IDisposablethat allows un-registering by callingDispose.Also fixes #681 by replacing the two distinct parameters
pathandsearchPatternwith aglobPattern(see here). If the pattern contains no directory slashes, the match will only be against the file name, otherwise it will be against the full path.