Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct the NotifyFilters in FileSystemWatcherMock when creating files #584

Merged
merged 2 commits into from
Apr 29, 2024

Conversation

vbreuss
Copy link
Member

@vbreuss vbreuss commented Apr 29, 2024

Currently NotifyFilters.DirectoryName is used instead of the correct NotifyFilters.FileName.

Also add tests to verify the behaviour.

@vbreuss vbreuss added the bug Something isn't working label Apr 29, 2024
@vbreuss vbreuss self-assigned this Apr 29, 2024
@vbreuss vbreuss enabled auto-merge (squash) April 29, 2024 07:24
Copy link

sonarcloud bot commented Apr 29, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

Stryker.NET mutation tested the changes in the pull request:
Mutation testing badge

@vbreuss vbreuss merged commit e47ab51 into main Apr 29, 2024
12 checks passed
@vbreuss vbreuss deleted the topic/fix-notifyfilter-when-creating-files branch April 29, 2024 07:44
Copy link

github-actions bot commented May 5, 2024

This is addressed in release v3.2.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working state: released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant