feat: support remaining properties of EnumerationOptions (#590)

* Add support for "IgnoreInaccessible"
Testably · May 5, 2024 · d6b88dc · d6b88dc
1 parent 29ccbad
commit d6b88dc
Show file tree

Hide file tree

Showing 2 changed files with 58 additions and 0 deletions.
diff --git a/Source/Testably.Abstractions.Testing/Storage/InMemoryStorage.cs b/Source/Testably.Abstractions.Testing/Storage/InMemoryStorage.cs
@@ -261,6 +261,17 @@ public IEnumerable<IStorageLocation> EnumerateLocations(
 				continue;
 			}
 
+			if (!_fileSystem.AccessControlStrategy
+				.IsAccessGranted(item.Key.FullPath, item.Value.Extensibility))
+			{
+				if (!enumerationOptions.IgnoreInaccessible)
+				{
+					throw ExceptionFactory.AccessToPathDenied(item.Key.FullPath);
+				}
+
+				continue;
+			}
+
 			if (type.HasFlag(item.Value.Type))
 			{
 				string name = _fileSystem.Execute.Path.GetFileName(item.Key.FullPath);

diff --git a/Tests/Testably.Abstractions.Tests/FileSystem/Directory/EnumerateDirectoriesTests.cs b/Tests/Testably.Abstractions.Tests/FileSystem/Directory/EnumerateDirectoriesTests.cs
@@ -1,6 +1,7 @@
 using System.Collections.Generic;
 using System.IO;
 using System.Linq;
+using Testably.Abstractions.Testing.FileSystem;
 
 namespace Testably.Abstractions.Tests.FileSystem.Directory;
 
@@ -208,6 +209,52 @@ public void
 	}
 #endif
 
+#if FEATURE_FILESYSTEM_ENUMERATION_OPTIONS
+	[SkippableTheory]
+	[InlineData(true)]
+	[InlineData(false)]
+	public void
+		EnumerateDirectories_WithEnumerationOptions_ShouldConsiderIgnoreInaccessible(
+			bool ignoreInaccessible)
+	{
+		Skip.IfNot(Test.RunsOnWindows);
+
+		string path = @"C:\Windows\System32";
+		EnumerationOptions enumerationOptions = new()
+		{
+			IgnoreInaccessible = ignoreInaccessible,
+			RecurseSubdirectories = true
+		};
+		if (FileSystem is MockFileSystem mockFileSystem)
+		{
+			FileSystem.Directory.CreateDirectory(
+				FileSystem.Path.Combine(path, "bar"));
+			FileSystem.Directory.CreateDirectory(
+				FileSystem.Path.Combine(path, "foo"));
+			mockFileSystem.WithAccessControlStrategy(
+				new DefaultAccessControlStrategy((p, _)
+					=> !p.EndsWith("foo", StringComparison.Ordinal)));
+		}
+
+		Exception? exception = Record.Exception(() =>
+		{
+			_ = FileSystem.Directory
+				.EnumerateDirectories(path, "*", enumerationOptions).ToList();
+		});
+
+		if (ignoreInaccessible)
+		{
+			exception.Should().BeNull();
+		}
+		else
+		{
+			exception.Should().BeException<UnauthorizedAccessException>(
+				messageContains: @"Access to the path 'C:\Windows\System32\",
+				hResult: -2147024891);
+		}
+	}
+#endif
+
 #if FEATURE_FILESYSTEM_ENUMERATION_OPTIONS
 	[SkippableTheory]
 	[InlineAutoData(MatchCasing.CaseInsensitive)]