Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid stacktrace when LDAP credentials server is down #426

Merged
merged 3 commits into from
Oct 7, 2024
Merged

Avoid stacktrace when LDAP credentials server is down #426

merged 3 commits into from
Oct 7, 2024

Conversation

byewokko
Copy link
Collaborator

@byewokko byewokko commented Oct 4, 2024 •
edited
Loading

When a request to LDAP credentials server fails with ldap.SERVER_DOWN, a warning is logged instead of unhandled stacktrace:

04-Oct-2024 18:40:10.574199 WARNING seacatauth.credentials.providers.ldap [sd provider_id="ad" uri="ldap://ad.example.int"] LDAP server is down.

@byewokko byewokko added the enhancement New feature or request label Oct 4, 2024
@byewokko byewokko self-assigned this Oct 4, 2024
@byewokko byewokko merged commit b25bdc5 into main Oct 7, 2024
2 checks passed
@byewokko byewokko deleted the fix/handle-ldap-server-down branch October 7, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@byewokko byewokko

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@byewokko