Merge pull request #381 from TeskaLabs/fix/ldap-authentication-logging

Do not log failed LDAP login as error
TeskaLabs · May 22, 2024 · 03412ad · 03412ad
2 parents e9b1785 + bc75a31
commit 03412ad
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -3,6 +3,7 @@
 ## v24.20
 
 ### Pre-releases
+- `v24.20-alpha4`
 - `v24.20-alpha3`
 - `v24.20-alpha2`
 - `v24.20-alpha1`
@@ -11,6 +12,7 @@
 - Default password criteria are more restrictive (#372, `v24.20-alpha1`, Compatible with Seacat Auth Webui v24.19-alpha and later, Seacat Account Webui v24.08-beta and later)
 
 ### Fix
+- Do not log failed LDAP login as error (#381, `v24.20-alpha4`)
 - Properly handle Argon2 verification error in login call (#378, `v24.20-alpha3`)
 
 ### Features

diff --git a/seacatauth/credentials/providers/ldap.py b/seacatauth/credentials/providers/ldap.py
@@ -360,7 +360,8 @@ def _authenticate_worker(self, credentials_id: str, credentials: dict) -> bool:
 		try:
 			lc.simple_bind_s(dn, password)
 		except ldap.INVALID_CREDENTIALS:
-			L.error("LDAP: Invalid credentials", struct_data={"dn": dn})
+			L.log(asab.LOG_NOTICE, "Authentication failed: Invalid LDAP credentials.", struct_data={
+				"cid": credentials_id, "dn": dn})
 			return False
 
 		lc.unbind_s()