Feature/lazy-loading #31
Conversation
There was a problem hiding this comment.
@petrKavulok Has it been tested properly? I have a feeling, that some containers was not working properly with lazy loading (not sure if it was resources or roles or some other...)
| @@ -38,8 +38,6 @@ function TenantDetailContainer(props) { | |||
| const [page, setPage] = useState(1); | |||
| const [filter, setFilter] = useState(""); | |||
| const limit = 10; | |||
| const [username, setUsername] = useState(); | |||
There was a problem hiding this comment.
@petrKavulok Ok, why were those items removed and why it is not in changelog or at least in the description of this PR then? Its very hard to distinguish from reviewers point of view, why this change has been made without any context .
There was a problem hiding this comment.
I removed it because I noticed that this functionality was already taken care of by the <Credentials /> component. I should have made a separate PR for that. Sorry, next time I'll separate it to two PRs
|
jj, it was. I also remember some of the containers not working, but I have not encountered any funny behaviour while testing |
| @@ -38,8 +38,6 @@ function TenantDetailContainer(props) { | |||
| const [page, setPage] = useState(1); | |||
| const [filter, setFilter] = useState(""); | |||
| const limit = 10; | |||
| const [username, setUsername] = useState(); | |||
There was a problem hiding this comment.
@petrKavulok PLease add the information about what has been removed and why to the changelog please :)
### in this PR
<Credentials />componentTODO: