Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor ClientCreateContainer #22

Merged
merged 43 commits into from
Mar 24, 2023
Merged

Refactor ClientCreateContainer #22

Show file tree
Hide file tree
Changes from 37 commits
Commits
Show all changes
43 commits
Select commit Hold shift + click to select a range
6c73996
replace customDataInput to new file
Mar 8, 2023
de2db63
refactor create inputs
Mar 8, 2023
dd14e24
add new row Login key
Mar 8, 2023
a096fb2
add login key obj to func
Mar 8, 2023
aa28529
rename prop
Mar 8, 2023
206de00
replace text and uri inputs
Mar 8, 2023
969fec0
update radio input
Mar 10, 2023
ac1d1a6
add login key and show custom btn
Mar 10, 2023
7950e0e
add new input auth uri, add locales, update assignValue func
Mar 10, 2023
1f744bb
rename prop for URIInput
Mar 10, 2023
5f3e361
remove login_key
Mar 10, 2023
6061650
add locales for new card in client edit
Mar 13, 2023
6eda92b
refactor client create component, add cards
Mar 13, 2023
fdb61cf
replace rows for new section
Mar 13, 2023
cfca14d
add new input singleCheckbox, add new input to assign function
Mar 14, 2023
a991988
add locales for added inputs and cards
Mar 15, 2023
7a0677c
add condition for defaultChecked radio input
Mar 15, 2023
87b2d94
add authorize anonymous usrs to detail
Mar 15, 2023
1b912ca
add new prop for radio btn, fix condition in the refactorSubmitData f…
Mar 15, 2023
ca46845
change cards icon
Mar 15, 2023
268406b
add new input redirect_uri_validation_method, locales for it
Mar 16, 2023
6ffb4d3
add missing setDisabled, fix condition for cookie domain
Mar 16, 2023
c205a64
fix condition for dispay authorize_anonymous_users
Mar 16, 2023
2d9c97f
refactor form to classname
Mar 20, 2023
534d9c3
update locales, add new CardHeader name, add new locales for ClientDe…
Mar 20, 2023
a922576
update headers and buttons name
Mar 20, 2023
1833469
refactor detail like a create container
Mar 20, 2023
6c0192c
add pkce to code challenge method
Mar 20, 2023
8956aff
remove unused code
Mar 20, 2023
aaee1d8
update changelog
Mar 20, 2023
d7c5b85
remove unused code, fix ident, update locales
Mar 21, 2023
5bbe0b6
Merge branch 'main' into refactor/update-clietns
Mar 22, 2023
7c06b58
add styles for grid
Mar 23, 2023
6cd3c3d
add comment with description
Mar 23, 2023
da11e03
add condition to code tag
Mar 23, 2023
b499e44
remove redunant condition and add comment to adv card
Mar 23, 2023
3485e67
remove setDisabled from submit new client
Mar 23, 2023
0e5cf66
prepare feedback
Mar 23, 2023
ad0096b
simplify assing value to inputs
Mar 24, 2023
c7122c4
resolve conflict
Mar 24, 2023
16b6e2f
update sprint number
Mar 24, 2023
514f29d
add one more condition for checking undefined
Mar 24, 2023
081624d
version bump
Mar 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@

- Webpack V4 to V5 migration. (INDIGO Sprint 230303, [!16](https://github.com/TeskaLabs/seacat-admin-webui/pull/16))

- Refactor Clients. Add new inputs `authorize_uri` and `redirect_uri_validation_method`. Refactor ClientDetail and ClientCreate to new format (divide to the cards). Update locales (INDIGO Sprint 230303, [!22](https://github.com/TeskaLabs/seacat-admin-webui/pull/22))

## v23.5

### Features
Expand Down
19 changes: 15 additions & 4 deletions public/locales/cs/translation.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,11 @@
"Client has been created": "Klient byl vytvořen",
"Something went wrong, client has not been created": "Něco je špatně, klient nebyl vytvořen",
"Create new client": "Vytvořit nového klienta",
"Create": "Vytvořit",
"Edit client": "Upravit klienta",
"Multidomain": "Multidoména",
"Access control": "Přístupová oprávnění",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Multidomain support": "Podpora více domén",
"Access control": "Řízení přístupů",

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@byewokko I got feedback from Alesh on the review and he said to use "Multidomain"

Copy link
Contributor

@byewokko byewokko Mar 23, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah okay ✨
i guess i understand his view, but still the czech word sounds super weird to me. i'll ask him when i get the chance.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@byewokko I'm not sure about the Czech version

"Authorization": "Autorizace",
"Template": "Šablona",
"Client name": "Název klienta",
"Preferred client ID": "Preferované ID klienta",
Expand All @@ -109,12 +113,14 @@
"Token endpoint authentication method": "Způsob autentikace pro získání tokenu",
"Cookie domain": "Cookie doména",
"Redirect URIs": "Seznam přesměrovácích URI",
"Redirect URI validation method": "Metoda ověření přesměrování URI",
"Create client": "Vytvořit klienta",
"Unknown item": "Neznámá položka",
"Code challenge methods": "Metody ověření kódu",
"Code challenge method (PKCE)": "Metod ověření kódu (PKCE)",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Metoda ověření kódu (PKCE)"

"Login URI": "URI přihlašovací stránky",
"Authorize URI": "Autorizace URI",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Autorizační URI"

"Authorize anonymous users": "Autorizace anonymních uživatelů",
"URI can't be empty": "URI nemůže být prázdný",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"URI nemůže být prázdné"

"URI have to start with https": "URI musí začínat https",
"URL hash have to be empty": "URL hash musí být prázdný"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"URL hash has to be empty"

},
"ClientDetailContainer": {
Expand All @@ -126,6 +132,9 @@
"Client removed successfully": "Klient úspěšně odstraněn",
"Something went wrong, failed to remove client": "Něco je špatně, nepodařilo se odstranit klienta",
"Client": "Klient",
"Multidomain": "Multidoména",
"Access control": "Přístupová oprávnění",
"Authorization": "Autorizace",
"Client name": "Název klienta",
"Client ID": "ID klienta",
"Reset secret": "Reset secret",
Expand All @@ -137,8 +146,11 @@
"Token endpoint auth. method": "Způsob autentikace pro získání tokenu",
"Cookie domain": "Cookie doména",
"Redirect URIs": "Seznam přesměrovácích URI",
"Code challenge methods": "Metody ověření kódu",
"Redirect URI validation method": "Metoda ověření přesměrování URI",
"Code challenge method (PKCE)": "Metod ověření kódu (PKCE)",
"Login URi": "Přihlášení URi",
"Authorize URI": "Autorizace URI",
"Authorize anonymous users": "Autorizace anonymních uživatelů",
"Redirect URI must be in absolute format without a fragment component.": "URI k přesměrování musí být v absolutním formátu a bez fragment komponenty.",
"Remove client": "Odstranit klienta",
"Save changes": "Uložit změny",
Expand All @@ -150,7 +162,6 @@
"Invalid format, input should have minimum of 8 characters": "Nesprávný formát, pole musí mít minimálně 8 znaků",
"Invalid format for cookie_domain": "Nesprávný formát pro cookie_domain",
"URI can't be empty": "URI nemůže být prázdný",
"URI have to start with https": "URI musí začínat https",
"URL hash have to be empty": "URL hash musí být prázdný",
"Choose an option": "Zvolte možnost",
"None": "Žádná",
Expand Down
19 changes: 16 additions & 3 deletions public/locales/en/translation.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,11 @@
"Client has been created": "Client has been created",
"Something went wrong, client has not been created": "Something went wrong, client has not been created",
"Create new client": "Create new client",
"Create": "Create",
"Edit client": "Edit client",
"Multidomain": "Multidomain",
"Access control": "Access control",
"Authorization": "Authorization",
"Template": "Template",
"Client name": "Client name",
"Preferred client ID": "Preferred client ID",
Expand All @@ -109,10 +113,14 @@
"Token endpoint authentication method": "Token endpoint authentication method",
"Cookie domain": "Cookie domain",
"Redirect URIs": "Redirect URIs",
"Redirect URI validation method": "Redirect URI validation method",
"Create client": "Create client",
"Unknown item": "Unknown item",
"Code challenge methods": "Code challenge methods",
"Code challenge method (PKCE)": "Code challenge method (PKCE)",
"Login URi": "Login URi",
"Authorize URI": "Authorize URI",
"Authorize anonymous users": "Authorize anonymous users",
"URI can't be empty": "URI can't be empty",
"URL hash have to be empty": "URL hash have to be empty",
"Choose an option": "Choose an option",
"Required field": "Required field"
Expand All @@ -126,6 +134,9 @@
"Client removed successfully": "Client removed successfully",
"Something went wrong, failed to remove client": "Something went wrong, failed to remove client",
"Client": "Client",
"Access control": "Access control",
"Multidomain": "Multidomain",
"Authorization": "Authorization",
"Client name": "Client name",
"Client ID": "Client ID",
"Reset secret": "Reset secret",
Expand All @@ -137,8 +148,11 @@
"Token endpoint auth. method": "Token endpoint auth. method",
"Cookie domain": "Cookie domain",
"Redirect URIs": "Redirect URIs",
"Code challenge methods": "Code challenge methods",
"Redirect URI validation method": "Redirect URI validation method",
"Code challenge method (PKCE)": "Code challenge method (PKCE)",
"Login URI": "Login URI",
"Authorize URI": "Authorize URI",
"Authorize anonymous users": "Authorize anonymous users",
"Redirect URI must be in absolute format without a fragment component.": "Redirect URI must be in absolute format without a fragment component.",
"Remove client": "Remove client",
"Save changes": "Save changes",
Expand All @@ -150,7 +164,6 @@
"Invalid format, input should have minimum of 8 characters": "Invalid format, input should have minimum of 8 characters",
"Invalid format for cookie_domain": "Invalid format for cookie_domain",
"URI can't be empty": "URI can't be empty",
"URI have to start with https": "URI have to start with https",
"URL hash have to be empty": "URL hash have to be empty",
"Choose an option": "Choose an option",
"None": "None",
Expand Down
Loading