Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error message when using invalid label #25

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

LexVocoder
Copy link

@LexVocoder LexVocoder commented Apr 25, 2018

It's sometimes not obvious what to use for the label field in Zanzifile. This error makes it clear what is available versus what the user requested.

It's sometimes not obvious what to use for the label field in Zanzifile.  This error makes it clear what is available versus what the user requested.
@LexVocoder
Copy link
Author

Build is failling... It looks like your CI needs maintenance? D-:

@TerribleDev
Copy link
Owner

Hi @maclennann do you mind working with @alexhankins to get this in?

Thanks M8!

@maclennann
Copy link
Collaborator

The publishing rights for this gem are currently owned solely by @jdcooke0117, who no longer works for Cimpress. While his rubygems API key is still stored in the travis.yml and we'd be able to publish this, there's no guarantee it will continue working (especially given that this hasn't been touched in over 2 years).

If we're going to make changes to this and publish a new version, we should find a new owner. Are either of you interested in maintaining this repo? We can transfer the repo to you (or another organization) and get JDC to grant you publishing rights on the gem.

@TerribleDev
Copy link
Owner

Hi @maclennann internally at vistaprint, we've developed a node based version of this package. However some teams are still on this older package.

Can we get @jdcooke0117 to give me rubygem rights (I'm terribledev on rubygems), and to transfer this repo to my personal github account. I can figure out the best place for this to go at a later date.

@jdaviscooke
Copy link

@TerribleDev I added you as an owner for the gem. I think someone else will have to move the repository, though. I don't think I have permissions to do that.

@maclennann
Copy link
Collaborator

maclennann commented May 18, 2018 via email

@maclennann
Copy link
Collaborator

@TerribleDev I can't transfer the repo because you currently have a fork. So either you'll need to temporarily remove your fork so I can transfer, or you can keep your fork as the new main repo and I can make a note in the README here and/or archive this repo.

@TerribleDev
Copy link
Owner

Hi @maclennann I have deleted the fork. Please try again!

@maclennann
Copy link
Collaborator

I've initiated the transfer (though turns out I had to transfer it to myself first).

@TerribleDev
Copy link
Owner

Thanks @maclennann I've accepted the transfer.

@LexVocoder
Copy link
Author

@TerribleDev did you want to approve this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants