Fix mod count text sometimes overlapping on filter buttons #798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes "Showing x mods" text overlapping on filter button with some (usually wide) window resolutions.
It's caused by button position being determined based on a string width during initialization (which was longer then usual, as mod list wasn't fully initialized, so it included "0/" prefix number of visible mods). Because of that, these buttons would be placed in the middle, despite text being visible, in cases where window is wide enough to fit shorter text (without "0/" prefix), but not wide enough to fit text with prefix.
This PR makes so that button size is determined on the size of text without "0/" prefix, which should be the shortest one and therefore fix the issue.
Example, before fix: