Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add addToBlockBasedItem annotation to InventoryComponent #17

Merged
merged 1 commit into from
May 29, 2020

Conversation

jdrueckert
Copy link
Member

@jdrueckert jdrueckert commented May 29, 2020

Fixes #16

When trying to nest items in a chest before ever having placed the chest, this doesn't work as the block based item "chest" doesn't have an InventoryComponent because this annotation is missing

- when trying to nest items in another item (e.g. chest) before ever having placed the chest, it doesn't have an `InventoryComponent` because this annotation is missing
@jdrueckert jdrueckert added the Type: Improvement Request for or addition/enhancement of a feature label May 29, 2020
@jdrueckert jdrueckert requested a review from skaldarnar May 29, 2020 20:40
@jdrueckert jdrueckert self-assigned this May 29, 2020
@skaldarnar skaldarnar merged commit 4f74b39 into develop May 29, 2020
@skaldarnar skaldarnar deleted the feat/add-addtoblockbaseditem-annotation branch May 29, 2020 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Improvement Request for or addition/enhancement of a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nested items in StartingInventory not working
2 participants