-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added nosql and dynamo plugins #429
base: master
Are you sure you want to change the base?
Conversation
<version>3.4</version> | ||
</dependency> | ||
|
||
<!-- for testing --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not necessary comment.
import static java.util.Objects.requireNonNull; | ||
|
||
/** | ||
* Created by amehta on 6/13/16. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove that.
import java.util.Properties; | ||
|
||
/** | ||
* Created by amehta on 6/13/16. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto
Seems like there are some code style failures. Can you reformat the code using code style defined in https://github.com/airlift/codestyle ? |
Please add Apache license header on all the new files |
@sclinebacker84 -- our apologies for not getting back to you sooner, but if you want to get this PR into upstream master (prestodb/presto), please submit a pull request there. |
added nosql counterpart to base-jdbc submodule
added dynamodb plugin