Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(angular): fixing dynamic menu open in new tab #2380

Merged
merged 2 commits into from
Feb 4, 2025

Conversation

owilliams320
Copy link
Collaborator

@owilliams320 owilliams320 commented Jan 31, 2025

Description

Adjusting the stylling for the dynamic menu item when its set to open in a new tab

What's included?

  • Fix styling for link opening in new tab

Test Steps

  • npm run start
  • then go to the dynamic menu examples under components
  • finally test the examples

General Tests for Every PR

  • npm run start still works.
  • npm run lint passes.
  • npm run stylelint passes.
  • npm test passes and code coverage is not lower.
  • npm run build still works.

Before

Screenshot 2025-01-31 at 2 26 09 PM
Screenshot 2025-01-31 at 2 26 01 PM

After

Screenshot 2025-01-31 at 2 25 44 PM
Screenshot 2025-01-31 at 2 25 38 PM

@owilliams320 owilliams320 temporarily deployed to covalent-pip-fix-dynami-rwxpj6 February 4, 2025 17:43 Inactive
@owilliams320 owilliams320 merged commit a22cd00 into main Feb 4, 2025
6 checks passed
@owilliams320 owilliams320 deleted the fix/dynamic-menu-style branch February 4, 2025 18:29
@owilliams320
Copy link
Collaborator Author

🎉 This PR is included in version 9.1.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant