ng-xi18n fails(aot support) #149

crain · 2016-11-11T14:10:26Z

This repository's issues are reserved for feature requests and bug reports.

Bug Report

Clone current covalent quickstart(https://github.com/Teradata/covalent-quickstart)
Run npm install
Run ./node_modules/.bin/ng-xi18n

What is the expected behavior?

No error

Which version of Angular and Material, and which browser and OS does this issue affect?

OS: Windows 10

Other information

Error: Error encountered resolving symbol values statically. Function calls are not supported. Consider replacing the function or lambda with a reference to an exported function, resolving symbol AppModule in C:/dev/covalent-quickstart/src/app/app.module.ts, resolving symbol AppModule in C:/dev/covalent-quickstart/src/app/app.module.ts
at simplifyInContext (C:\dev\covalent-quickstart\node_modules@angular\compiler-cli\src\static_reflector.js:470:23)
at StaticReflector.simplify (C:\dev\covalent-quickstart\node_modules@angular\compiler-cli\src\static_reflector.js:473:22)
at StaticReflector.annotations (C:\dev\covalent-quickstart\node_modules@angular\compiler-cli\src\static_reflector.js:60:36)
at NgModuleResolver.resolve (C:\dev\covalent-quickstart\node_modules@angular\compiler\bundles\compiler.umd.js:14050:46)
at CompileMetadataResolver.getNgModuleMetadata (C:\dev\covalent-quickstart\node_modules@angular\compiler\bundles\compiler.umd.js:14296:49)
at C:\dev\covalent-quickstart\node_modules@angular\compiler\bundles\compiler.umd.js:13284:43
at Array.forEach (native)
at _extractModulesAndPipesOrDirectives (C:\dev\covalent-quickstart\node_modules@angular\compiler\bundles\compiler.umd.js:13283:28)
at Object.analyzeNgModules (C:\dev\covalent-quickstart\node_modules@angular\compiler\bundles\compiler.umd.js:13039:16)
at Extractor.extract (C:\dev\covalent-quickstart\node_modules@angular\compiler-cli\src\extractor.js:34:30)
Extraction failed

crain · 2016-11-11T15:33:17Z

Could be related to angular/angular-cli#2814 and angular/angular-cli#2201

crain · 2016-11-14T15:42:09Z

Some further investigations:
It looks like that covalent needs to support aot to support native i18n in angular2.

The above error results from calling the following in my module:

imports: [
CovalentCoreModule.forRoot()
]

To "fix" this issue I refactored my code to use an exported function such as:

export function covalentCoreModule() {
  return CovalentCoreModule.forRoot()
}

and using this in imports:

imports: [
covalentCoreModule
]

Which brings to me to the next error:

Error: Unexpected value 'coreModule' imported by the module 'AppModule'
at C:\dev\covalent-quickstart\node_modules@angular\compiler\bundles\compiler.umd.js:14326:37
at Array.forEach (native)
at CompileMetadataResolver.getNgModuleMetadata (C:\dev\covalent-quickstart\node_modules@angular\compiler\bundles\compiler.umd.js:14311:46)
at C:\dev\covalent-quickstart\node_modules@angular\compiler\bundles\compiler.umd.js:13284:43
at Array.forEach (native)
at _extractModulesAndPipesOrDirectives (C:\dev\covalent-quickstart\node_modules@angular\compiler\bundles\compiler.umd.js:13283:28)
at Object.analyzeNgModules (C:\dev\covalent-quickstart\node_modules@angular\compiler\bundles\compiler.umd.js:13039:16)
at Extractor.extract (C:\dev\covalent-quickstart\node_modules@angular\compiler-cli\src\extractor.js:34:30)
at extract (C:\dev\covalent-quickstart\node_modules@angular\compiler-cli\src\extract_i18n.js:19:35)
at Object.main (C:\dev\covalent-quickstart\node_modules@angular\tsc-wrapped\src\main.js:30:16)
Extraction failed

According to(angular/angular#11262) this issue relates to the fact that there is no metadata.json available per module which will be generated by executing the angular compiler with "ngc -p tsconfig.json" instead of using typescript.

I tried to play arround with building covalent with ngc instead of typescript but it fails because ngc does not support scss(angular/angular#11815) compilation and it needs to be done beforehand.

I am not fully aware of the build process behind covalent but I hope my first investigations give some insights.

emoralesb05 · 2016-11-14T18:27:20Z

Thanks for the info. We havent done any AoT testing, but its in our radar and roadmap. Ill start researching about what we need to do in the building/publishing process to allow that.

Any additional info you can find would be awesome!

asaph26 · 2016-12-15T11:53:57Z

@emoralesb05 This is short summary of getting it up and ready with AOT Support
https://medium.com/@isaacplmann/getting-your-angular-2-library-ready-for-aot-90d1347bcad#.jbe1qjx8u

emoralesb05 · 2016-12-15T15:00:09Z

Awesome, ill check this articule out since AoT support is needed more and more every day.

Thanks!

emoralesb05 · 2016-12-26T04:00:24Z

Hopefully #209 will resolve this.

…al AoT support. closes(#149) (#209) * upgrade to angular 2.4.1 and rxjs 5.0.1 * upgrade [email protected] * replaced svgSrc with svgIcon in layouts * register icons from assets into the MdIconRegistry * updated certain layouts and layout docs * fixed svg usage in home, layouts overview and styleguide * updated icon documentation * updated docs with "assets:iconname" * update unit tests with hammerjs * remove usage of depricated md-input infavor of md-input-container (expect in autocomplete) * remove deprecated kabab md directives * replaced portalHost with cdkPortalHost * replaced md-progress-circle with md-progress-spinner * replaced md-sidenav-layout with md-sidenav-container * replaced align with labelPosition in md-checkbox * used labelPosition="before" explicitly now since default is "after" * renamed focus-trap into cdk-focus-trap * make `npm run test` do an ng test with generated code coverage , check linting and run once * clean scss files and themes for future AoT support * updated build.conf.js to move ts files excluding spec and app/ ts files * fixed chart ParseContent enum so its AoT compatible * missed highlight theme file * upgrade to [email protected] * fixed teradata-ux svg * fixed `npm run test` command * update .npmignore with aot files that dont need to be published * changed TS module compilation to es2015 since its needed for tree shaking * initial AoT tsconfig * add `npm run aot` for AoT compilation on platform * script to remove unwanted AoT files from platform publish * updated `npm run buiild` to include AoT process * removed relative path imports from charts and data-table themes * updated published package.json's from core and http modules * fixed stepper unit tests * feature(nav-list): better responsive widths * fix(manage-list): ensure box shadows are correct on desktop * fix(layout-theme): needed class for bg color * fixed bug in layouts where it didnt close the sidenav in some cases * update(material-components): add md-select & updates * removing obsolete validation * use any[] instead of object in select docs * fixed tslint errors * update copy in FAQ * removed the deprecated md-tooltip * spelling/language check * update(material-components): add chips example * update(platform.css): add sidenav * update(material-components): dialogs from material2

emoralesb05 · 2016-12-29T01:25:25Z

Should be fixed in 0.10.
If the issue still persists please fill free to reopen 😄

rodislav · 2016-12-29T09:29:00Z

when do you plan to release this version ? (0.10) this issue is kinda blocker for us

emoralesb05 · 2016-12-29T18:29:40Z

We are working hard to release asap. Adding more goodies to the release 😄

rodislav · 2016-12-29T18:30:57Z

Cool, thanks! Le jeu. 29 déc. 2016 19:29, Ed Morales <[email protected]> a écrit :

We are working hard to release asap. Adding more goodies to the release 😄 — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#149 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAdrXLU0n1rPL-aPu9kUtodk2XP-Gk4tks5rM_wVgaJpZM4Kvx-L> .

-- ------------------------------------------------------------------------------------------------ "Love is all around! Enjoy!" * HTML* Please read this message with html support enabled *P*lease don't print this e-mail unless you really need to

sarath-sasikumar · 2017-01-11T07:30:11Z

The typescript version other than 2.0.10 is having an issue with the covalent/core/file/directive/file-drop.directive.ts regarding the type of DOMStringList

Argument of type 'string[]' is not assignable to parameter of type 'DOMStringList'.

It is probably an issue with typescript which is there in all the higher versions causing an error during the build

emoralesb05 · 2017-01-11T17:12:50Z

Yep, we are aware if this since angular didnt support [email protected] until 2.4.2. We just merged a PR that will fix this. #241

crain closed this as completed Nov 12, 2016

crain reopened this Nov 14, 2016

crain changed the title ~~ng-xi18n fails~~ ng-xi18n fails(aot support) Nov 18, 2016

emoralesb05 added this to the Alpha 0.10 milestone Dec 19, 2016

emoralesb05 added the enhancement label Dec 19, 2016

emoralesb05 mentioned this issue Dec 26, 2016

feature(deps): upgrade to @[email protected] and @[email protected] + initial AoT support. closes(#149) #209

Merged

8 tasks

emoralesb05 self-assigned this Dec 26, 2016

emoralesb05 closed this as completed Dec 29, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ng-xi18n fails(aot support) #149

ng-xi18n fails(aot support) #149

crain commented Nov 11, 2016

crain commented Nov 11, 2016

crain commented Nov 14, 2016 •

edited

Loading

emoralesb05 commented Nov 14, 2016 •

edited

Loading

asaph26 commented Dec 15, 2016

emoralesb05 commented Dec 15, 2016 •

edited

Loading

emoralesb05 commented Dec 26, 2016

emoralesb05 commented Dec 29, 2016

rodislav commented Dec 29, 2016

emoralesb05 commented Dec 29, 2016

rodislav commented Dec 29, 2016 via email

sarath-sasikumar commented Jan 11, 2017

emoralesb05 commented Jan 11, 2017

ng-xi18n fails(aot support) #149

ng-xi18n fails(aot support) #149

Comments

crain commented Nov 11, 2016

Bug Report

What is the expected behavior?

Which version of Angular and Material, and which browser and OS does this issue affect?

Other information

crain commented Nov 11, 2016

crain commented Nov 14, 2016 • edited Loading

emoralesb05 commented Nov 14, 2016 • edited Loading

asaph26 commented Dec 15, 2016

emoralesb05 commented Dec 15, 2016 • edited Loading

emoralesb05 commented Dec 26, 2016

emoralesb05 commented Dec 29, 2016

rodislav commented Dec 29, 2016

emoralesb05 commented Dec 29, 2016

rodislav commented Dec 29, 2016 via email

sarath-sasikumar commented Jan 11, 2017

emoralesb05 commented Jan 11, 2017

crain commented Nov 14, 2016 •

edited

Loading

emoralesb05 commented Nov 14, 2016 •

edited

Loading

emoralesb05 commented Dec 15, 2016 •

edited

Loading