Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix mmap constructor, add UAIInstance pretty printing #45

Merged
merged 7 commits into from
Jul 11, 2023
Merged

Fix mmap constructor, add UAIInstance pretty printing #45

merged 7 commits into from
Jul 11, 2023

Conversation

GiggleLiu
Copy link
Member

@GiggleLiu GiggleLiu commented Jul 11, 2023 •
edited
Loading

Fix #40

@GiggleLiu GiggleLiu requested a review from mroavi July 11, 2023 17:11
@GiggleLiu
Copy link
Member Author

Oh no, I worked on the documentation PR. Let me close another one.

@GiggleLiu GiggleLiu mentioned this pull request Jul 11, 2023
Closed
@codecov
Copy link

codecov bot commented Jul 11, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@e5ae5a2). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #45   +/-   ##
=======================================
  Coverage        ?   61.67%           
=======================================
  Files           ?        9           
  Lines           ?      467           
  Branches        ?        0           
=======================================
  Hits            ?      288           
  Misses          ?      179           
  Partials        ?        0

mroavi
mroavi approved these changes Jul 11, 2023
View reviewed changes
Copy link
Collaborator

@mroavi mroavi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@mroavi mroavi merged commit 57f5068 into main Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroavi mroavi mroavi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor MMAPModel such that it takes the query vars instead of the marginalzed vars
2 participants
@GiggleLiu @mroavi