-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rescale tensors and choose correct contraction order optimizer in tests #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UpdateNow I use the following solution to the rescaling problem:
struct RescaledArray{T, N, AT<:AbstractArray{T, N}} <: AbstractArray{T, N}
logf::T
value::AT
end It represents array
for CT in [:DynamicEinCode, :StaticEinCode]
@eval function OMEinsum.einsum(code::$CT, @nospecialize(xs::NTuple{N,RescaledArray}), size_dict::Dict) where N
res = einsum(code, getfield.(xs, :value), size_dict)
return rescale_array(RescaledArray(sum(x->x.logf, xs), res))
end
end
|
mroavi
reviewed
Nov 2, 2022
mroavi
reviewed
Nov 2, 2022
mroavi
reviewed
Nov 2, 2022
mroavi
reviewed
Nov 3, 2022
mroavi
reviewed
Nov 3, 2022
mroavi
reviewed
Nov 3, 2022
mroavi
reviewed
Nov 3, 2022
mroavi
reviewed
Nov 3, 2022
GiggleLiu
changed the title
[WIP] Rescale tensors and choose correct contraction order optimizer in tests
Rescale tensors and choose correct contraction order optimizer in tests
Nov 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, I
Test Report
For "relational" dataset, none of the optimizers in
OMEinsum
find any proper contraction order. (there are more than 60k tensors, the size is too big I think).The rest instances all pass except
linkage_15
fails andObjectDetection_35
, I still do not have any clue about why these two instances are so special.