-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed a sync problem #15
Conversation
Please try this test case, I am afraid it is fully fixed: using GenericTensorNetworks, GenericTensorNetworks.Graphs
using CUDA
using Random; Random.seed!(6)
g = Graphs.random_regular_graph(200, 3)
item(x::AbstractArray) = Array(x)[]
optimizer = TreeSA(ntrials=1)
gp = IndependentSet(g; optimizer=optimizer)
contraction_complexity(gp)
@time CUDA.@sync solve(gp, SizeMax(); usecuda=true, T=Float32)
using CuTropicalGEMM
@time CUDA.@sync solve(gp, SizeMax(); usecuda=true, T=Float32) |
The test passed, and I also double checked the result on another server. Did you rebuild the binary after pull? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just verified the correctness. Good job! After fixing the Project.toml and CI, we can release v0.1.
Project.toml
Outdated
@@ -6,6 +6,7 @@ version = "1.0.0-DEV" | |||
[deps] | |||
ArtifactUtils = "8b73e784-e7d8-4ea5-973d-377fed4e3bce" | |||
Artifacts = "56f22d72-fd6d-98f1-02f0-08ddc0907c33" | |||
BenchmarkTools = "6e4b80f9-dd63-53aa-95a3-0cdb28fa8baf" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove all dependencies that not directly used in src from the Project.toml
If you want a test environment, please add a Project.toml file to the test folder, example: https://github.com/TensorBFS/TensorInference.jl/tree/main/test
TestEnv.jl can help you start a test environment for debugging easily.
For packages like BenchmarkTools, they should not be included in the local environment.
We need to get this PR merged before closing issue #10 Approve means you get the permission to merge this PR directly. |
The main change is by force sync in the C code, the problem mentioned in #10 is fixed, results are shown as
The result now is stable and the macro
@time
works properly.I also removed the unused files
.travis.yml
andArtifacts.toml
, as mentioned in #12.