Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add some C++ vs plugins #45

Merged
merged 9 commits into from
Jan 29, 2025
Merged

feat: add some C++ vs plugins #45

merged 9 commits into from
Jan 29, 2025

Conversation

Tohrusky
Copy link
Member

@Tohrusky Tohrusky commented Jan 29, 2025

Summary by Sourcery

Build:

  • Add libtbb-dev to the apt install list.

Copy link

sourcery-ai bot commented Jan 29, 2025

Reviewer's Guide by Sourcery

This pull request adds several new VapourSynth C++ plugins to the Dockerfile, including those from HomeOfAviSynthPlusEvolution, Irrational-Encoding-Wizardry, dubhater, and TensoRaws. It also updates the list of installed plugins in the README.md file.

Class diagram showing plugin organization

classDiagram
    class VapourSynth {
        +load_plugin()
    }

    class HomeOfAviSynthPlusEvolution {
        +neo_FFT3D
        +neo_DFTTest
        +neo_f3kdb
    }

    class IrrationalEncodingWizardry {
        +RemapFrames
    }

    class Dubhater {
        +flux
        +nnedi3
        +tedgemask
        +sangnom
    }

    class TensoRaws {
        +descale
        +hqdn3d
        +d2vsource
        +znedi3
        +placebo
    }

    VapourSynth <|-- HomeOfAviSynthPlusEvolution
    VapourSynth <|-- IrrationalEncodingWizardry
    VapourSynth <|-- Dubhater
    VapourSynth <|-- TensoRaws

    note for VapourSynth "Core system that loads plugins"
    note for HomeOfAviSynthPlusEvolution "Frequency domain filters"
    note for TensoRaws "Video processing plugins"
Loading

File-Level Changes

Change Details Files
Added several new VapourSynth C++ plugins.
  • Added vs-removegrain plugin.
  • Added neo_FFT3D, neo_DFTTest, and neo_f3kdb plugins.
  • Added RemapFrames plugin.
  • Added flux, nnedi3, tedgemask, and sangnom plugins.
  • Added descale, hqdn3d, d2vsource, znedi3, and vs-placebo plugins.
  • Added nlm_cuda plugin.
vs-pytorch.dockerfile
vs-pytorch-rocm.dockerfile
Updated the README.md file to include the newly added plugins.
  • Added a list of VapourSynth Python plugins.
  • Added the newly added C++ plugins to the VapourSynth C++ Plugin List.
README.md

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Tohrusky - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟡 General issues: 1 issue found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

-D CMAKE_BUILD_TYPE=Release \
-D CMAKE_CXX_FLAGS="-Wall -ffast-math -march=x86-64-v3" \
-D CMAKE_CUDA_FLAGS="--threads 0 --use_fast_math --resource-usage -Wno-deprecated-gpu-targets" \
-D CMAKE_CUDA_ARCHITECTURES="50;52-real;60;61-real;70;75-real;80;86-real;89-real;90-real" && \
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: Make CUDA architectures configurable via build arg

Consider using a Docker build argument to allow customization of target CUDA architectures without modifying the Dockerfile.

Suggested implementation:

# Define build argument for CUDA architectures with a default value
ARG CUDA_ARCHITECTURES="50;52-real;60;61-real;70;75-real;80;86-real;89-real;90-real"

# nlm_cuda
RUN git clone https://github.com/AmusementClub/vs-nlm-cuda && cd vs-nlm-cuda && \

    -D CMAKE_CUDA_ARCHITECTURES="${CUDA_ARCHITECTURES}" && \

@Tohrusky Tohrusky merged commit 8fc157c into TensoRaws:main Jan 29, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant