-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add some C++ vs plugins #45
Conversation
Reviewer's Guide by SourceryThis pull request adds several new VapourSynth C++ plugins to the Dockerfile, including those from HomeOfAviSynthPlusEvolution, Irrational-Encoding-Wizardry, dubhater, and TensoRaws. It also updates the list of installed plugins in the README.md file. Class diagram showing plugin organizationclassDiagram
class VapourSynth {
+load_plugin()
}
class HomeOfAviSynthPlusEvolution {
+neo_FFT3D
+neo_DFTTest
+neo_f3kdb
}
class IrrationalEncodingWizardry {
+RemapFrames
}
class Dubhater {
+flux
+nnedi3
+tedgemask
+sangnom
}
class TensoRaws {
+descale
+hqdn3d
+d2vsource
+znedi3
+placebo
}
VapourSynth <|-- HomeOfAviSynthPlusEvolution
VapourSynth <|-- IrrationalEncodingWizardry
VapourSynth <|-- Dubhater
VapourSynth <|-- TensoRaws
note for VapourSynth "Core system that loads plugins"
note for HomeOfAviSynthPlusEvolution "Frequency domain filters"
note for TensoRaws "Video processing plugins"
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Tohrusky - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
-D CMAKE_BUILD_TYPE=Release \ | ||
-D CMAKE_CXX_FLAGS="-Wall -ffast-math -march=x86-64-v3" \ | ||
-D CMAKE_CUDA_FLAGS="--threads 0 --use_fast_math --resource-usage -Wno-deprecated-gpu-targets" \ | ||
-D CMAKE_CUDA_ARCHITECTURES="50;52-real;60;61-real;70;75-real;80;86-real;89-real;90-real" && \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion: Make CUDA architectures configurable via build arg
Consider using a Docker build argument to allow customization of target CUDA architectures without modifying the Dockerfile.
Suggested implementation:
# Define build argument for CUDA architectures with a default value
ARG CUDA_ARCHITECTURES="50;52-real;60;61-real;70;75-real;80;86-real;89-real;90-real"
# nlm_cuda
RUN git clone https://github.com/AmusementClub/vs-nlm-cuda && cd vs-nlm-cuda && \
-D CMAKE_CUDA_ARCHITECTURES="${CUDA_ARCHITECTURES}" && \
Summary by Sourcery
Build: