Fix for parallel racing functional test #80
Conversation
Jenkinsfile
Outdated
| sh "rm -rf ${env.WORKSPACE}_${currentCiGroup}" | ||
| sh "mkdir ${env.WORKSPACE}_${currentCiGroup}" | ||
| sh "rm -rf ${env.WORKSPACE}/.optimize/${currentCiGroup}" | ||
| sh "mkdir ${env.WORKSPACE}/.optimize/${currentCiGroup}" |
There was a problem hiding this comment.
You might want to use -p. Otherwise it could fail if running for the first time, when .optimize directory does not exist
There was a problem hiding this comment.
mkdir -p, making sure this is tested in bfs7.7.1_test branch
There was a problem hiding this comment.
-p option has been added to ensure directory path.
Test job has been run: https://jenkins.bfs.sichend.people.aws.dev/blue/organizations/jenkins/Kibana/detail/bfs7.7.1_test/18/pipeline/
There was a problem hiding this comment.
rm -rf /var/lib/jenkins/workspace/Kibana_bfs7.7.1_test_ciGroup9
This is not right in the test run.
There was a problem hiding this comment.
Hi, @sichend. I sent the wrong link. To verify, a new job was created. It points to the right directory path /var/lib/jenkins/workspace/.optimize/ Below is the build link: https://jenkins.bfs.sichend.people.aws.dev/blue/organizations/jenkins/Kibana/detail/bfs7.7.1_test/19/pipeline/60/
There was a problem hiding this comment.
Good to go. However make sure to fix these two things
- Update the PR title from "Fix optimization" to something more meaningful. PR title is going to be the commit message after merge. Commit message should be concise and descriptive. For example: "Fix disk racing condition for parallel functional test"
- Make sure to use squash merge
Thanks for insisting on a high standard.
Description
This PR creates a temporary directory within the current workspace to mount the bundles in docker environment.
Closes #57