Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skipped Capabilities Test #65

Conversation

Carthanial
Copy link

@Carthanial Carthanial commented Nov 22, 2021

Description :

This test was the last test failing in the Jenkins Unit Test stage. It was failing due to there being no legacy plugin specs which were created by internal tools that have been deprecated from them migrating Capabilities to a new platform. Therefore it will be skipped and the description added in comments.

Closes Issue #58

@Carthanial Carthanial added bug Something isn't working enhancement New feature or request labels Nov 22, 2021
zhyuanqi
zhyuanqi previously approved these changes Nov 22, 2021
@zhyuanqi zhyuanqi self-requested a review November 23, 2021 00:05
@zhyuanqi
Copy link
Collaborator

Hi I reviewed the content again and revoke the approval. We need to take about this again tomorrow morning

@zhyuanqi zhyuanqi dismissed their stale review November 23, 2021 00:13

Found a issue

@zhyuanqi
Copy link
Collaborator

zhyuanqi commented Nov 23, 2021

Hi. This capabilities is sill in use https://github.com/elastic/kibana/blob/7.15/docs/development/core/public/kibana-plugin-core-public.capabilities.md. We might need to move it from legacy platform to kibana platform(https://www.elastic.co/guide/en/kibana/current/migrating-legacy-plugins.html) since currently it is not working due to kbnServer.pluginSpecs has been deprecated. Found a related PR which might be useful. Here are the next steps:

  • Figure out what is this capabilities and why we need it

  • Try to use capabilities and see if any error message shows up. (Should be some since it is not working now)

  • After this, we can talk about possible solutions

@Carthanial Carthanial linked an issue Nov 30, 2021 that may be closed by this pull request
@Carthanial Carthanial closed this Dec 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Node V12.22.7 Integration Test Failures
3 participants