Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix golangci-lint problems #2428

Merged
merged 2 commits into from
Aug 21, 2023

Conversation

AlkaidChan
Copy link
Collaborator

No description provided.

@AlkaidChan AlkaidChan added the bcs-bscp feature or bugfix for bscp label Aug 11, 2023
@AlkaidChan AlkaidChan requested a review from ifooth August 11, 2023 13:06
@@ -120,64 +120,6 @@ func mig20230526152150GormUp(tx *gorm.DB) error {
// mig20230526152150GormDown for down migration
func mig20230526152150GormDown(tx *gorm.DB) error {

// Hook 脚本
type Hook struct {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里删掉的作用是?

@@ -186,7 +186,7 @@ func (gt *GreaterThanType) Match(match *Element, labels map[string]string) (bool
return false, nil
}

to, err := strconv.ParseFloat(compare, 10)
to, err := strconv.ParseFloat(compare, 32)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个转换,以前一直是错误的么?

@ifooth ifooth merged commit 2a8c12a into TencentBlueKing:master Aug 21, 2023
wenxinlee2015 added a commit that referenced this pull request Aug 22, 2023
* github-bk-bcs/master:
  部署脚本选用bcs-apiserver-proxy作为默认高可用方案 #2413 (#2467)
  fix golangci-lint problems (#2428)
  修复 SDK API 版本匹配问题 (#2464)
  cluster-resource pod下容器列表新增initContainer (#2438)
  Update: use uint32 for version (#2452)
  Update: use semver for bscp version (#2451)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bcs-bscp feature or bugfix for bscp
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants