fix(stage): render destroy后移除load事件

Tencent · Mar 29, 2022 · f03281a · f03281a
1 parent 504adcb
commit f03281a
Showing 1 changed file with 12 additions and 9 deletions.
diff --git a/packages/stage/src/StageRender.ts b/packages/stage/src/StageRender.ts
@@ -52,15 +52,7 @@ export default class StageRender extends EventEmitter {
       height: 100%;
     `;
 
-    this.iframe.onload = async () => {
-      this.emit('onload');
-      if (this.render) {
-        const el = await this.render(this.core);
-        if (el) {
-          this.iframe?.contentDocument?.body?.appendChild(el);
-        }
-      }
-    };
+    this.iframe.addEventListener('load', this.loadHandler);
   }
 
   public getMagicApi = () => ({
@@ -113,9 +105,20 @@ export default class StageRender extends EventEmitter {
    * 销毁实例
    */
   public destroy(): void {
+    this.iframe?.removeEventListener('load', this.loadHandler);
     this.contentWindow = null;
     this.iframe?.remove();
     this.iframe = undefined;
     this.removeAllListeners();
   }
+
+  private loadHandler = async () => {
+    this.emit('onload');
+    if (this.render) {
+      const el = await this.render(this.core);
+      if (el) {
+        this.iframe?.contentDocument?.body?.appendChild(el);
+      }
+    }
+  };
 }