Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dialog): 1、修复普通对话框 不脱离文档流 #994

Merged
merged 7 commits into from
Jun 14, 2022

Conversation

huoyuhao
Copy link
Contributor

@huoyuhao huoyuhao commented Jun 13, 2022

🤔 这个 PR 的性质是?

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

💡 需求背景和解决方案

部分组件新增ref参数
涉及组件:Anchor,Badge,Collapse

📝 更新日志

  • fix(dialog): 修复普通对话框 不脱离文档流

  • fix(dialog): 修复点击对话框后对话框会隐藏问题

  • fix(dialog): 修复modeless 模式 背景样式点击透传

  • fix(dialog): 修复attach挂载showInAttachedElement定位问题

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

1、修复普通对话框 不脱离文档流

fix Tencent#993
@github-actions
Copy link
Contributor

github-actions bot commented Jun 13, 2022

完成

modeless 点击穿透
@codecov-commenter
Copy link

codecov-commenter commented Jun 13, 2022

Codecov Report

Merging #994 (783af72) into develop (a0db0df) will increase coverage by 2.06%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop     #994      +/-   ##
===========================================
+ Coverage    57.56%   59.62%   +2.06%     
===========================================
  Files          346      382      +36     
  Lines        12828    14617    +1789     
  Branches      2405     2743     +338     
===========================================
+ Hits          7384     8715    +1331     
- Misses        5200     5635     +435     
- Partials       244      267      +23     
Impacted Files Coverage Δ
src/affix/affix.tsx 28.57% <0.00%> (-37.51%) ⬇️
src/swiper/props.ts 68.75% <0.00%> (-31.25%) ⬇️
src/dialog/props.ts 70.00% <0.00%> (-30.00%) ⬇️
src/calendar/props.ts 70.00% <0.00%> (-30.00%) ⬇️
src/popup/props.ts 75.00% <0.00%> (-25.00%) ⬇️
src/select/props.ts 75.00% <0.00%> (-25.00%) ⬇️
src/slider/props.ts 75.00% <0.00%> (-25.00%) ⬇️
src/message/props.ts 75.00% <0.00%> (-25.00%) ⬇️
src/tooltip/props.ts 75.00% <0.00%> (-25.00%) ⬇️
src/pagination/props.ts 75.00% <0.00%> (-25.00%) ⬇️
... and 160 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc7b884...783af72. Read the comment docs.

@uyarn uyarn merged commit 55f7578 into Tencent:develop Jun 14, 2022
@github-actions github-actions bot mentioned this pull request Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants