Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(progress): 环形进度条显示比例不准确 #874

Merged
merged 1 commit into from
May 13, 2022

Conversation

LoopZhou
Copy link
Collaborator

@LoopZhou LoopZhou commented May 13, 2022

🤔 这个 PR 的性质是?

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

Fixes #872

💡 需求背景和解决方案

环形进度条显示比例不准确,会比正常情况下长。应该是半径计算出错导致。

📝 更新日志

  • fix(progress): 环形进度条显示比例不准确

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

@codecov-commenter
Copy link

Codecov Report

Merging #874 (b2ce668) into develop (a0db0df) will increase coverage by 3.81%.
The diff coverage is 68.80%.

@@             Coverage Diff             @@
##           develop     #874      +/-   ##
===========================================
+ Coverage    57.56%   61.37%   +3.81%     
===========================================
  Files          346      355       +9     
  Lines        12828    13467     +639     
  Branches      2405     2567     +162     
===========================================
+ Hits          7384     8266     +882     
+ Misses        5200     4940     -260     
- Partials       244      261      +17     
Impacted Files Coverage Δ
src/avatar/group.tsx 97.14% <ø> (ø)
src/breadcrumb/breadcrumb-item-props.ts 100.00% <ø> (ø)
src/calendar/props.ts 70.00% <0.00%> (-30.00%) ⬇️
src/cascader/props.ts 91.66% <ø> (ø)
src/cascader/utils/inputContent.ts 59.45% <0.00%> (+6.68%) ⬆️
src/date-picker/date-picker.tsx 46.57% <0.00%> (+0.72%) ⬆️
src/date-picker/panel/date-range.tsx 7.48% <0.00%> (+0.29%) ⬆️
src/dialog/props.ts 70.00% <0.00%> (-30.00%) ⬇️
src/dropdown/dropdown-menu.tsx 18.42% <ø> (ø)
src/dropdown/dropdown.tsx 70.00% <0.00%> (+5.00%) ⬆️
... and 134 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5d7ce8...b2ce668. Read the comment docs.

@github-actions
Copy link
Contributor

完成

@uyarn uyarn merged commit 2738377 into Tencent:develop May 13, 2022
@github-actions github-actions bot mentioned this pull request May 13, 2022
@LoopZhou LoopZhou deleted the fix/loopzhou-progress branch August 3, 2022 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Progress] 环形进度条显示比例不准确
3 participants