Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dialog): dialog lock when preventScrollThrough and modal mode #861

Merged
merged 1 commit into from
May 10, 2022

Conversation

uyarn
Copy link
Collaborator

@uyarn uyarn commented May 10, 2022

🤔 这个 PR 的性质是?

  • 日常 bug 修复 修复Dialog默认都加入lock的问题

🔗 相关 Issue

💡 需求背景和解决方案

📝 更新日志

  • fix(Dialog): 修复normal下加入lock导致页面无法滚动的问题

  • feat(Dialog): 支持preventScrollThrough API

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

@uyarn uyarn force-pushed the fix/dialog-lock branch from d962e85 to ee1fa27 Compare May 10, 2022 10:27
@github-actions
Copy link
Contributor

Size Change: +22 B (0%)

Total Size: 640 kB

Filename Size Change
./dist/tdesign.js 355 kB +13 B (0%)
./dist/tdesign.min.js 204 kB +9 B (0%)
ℹ️ View Unchanged
Filename Size
./dist/tdesign.css 43 kB
./dist/tdesign.min.css 38.2 kB

@codecov-commenter
Copy link

codecov-commenter commented May 10, 2022

Codecov Report

Merging #861 (f598235) into develop (a0db0df) will increase coverage by 3.82%.
The diff coverage is 69.12%.

@@             Coverage Diff             @@
##           develop     #861      +/-   ##
===========================================
+ Coverage    57.56%   61.38%   +3.82%     
===========================================
  Files          346      355       +9     
  Lines        12828    13456     +628     
  Branches      2405     2554     +149     
===========================================
+ Hits          7384     8260     +876     
+ Misses        5200     4937     -263     
- Partials       244      259      +15     
Impacted Files Coverage Δ
src/avatar/group.tsx 97.14% <ø> (ø)
src/breadcrumb/breadcrumb-item-props.ts 100.00% <ø> (ø)
src/calendar/props.ts 70.00% <0.00%> (-30.00%) ⬇️
src/cascader/props.ts 91.66% <ø> (ø)
src/cascader/utils/inputContent.ts 59.45% <0.00%> (+6.68%) ⬆️
src/date-picker/date-picker.tsx 46.57% <0.00%> (+0.72%) ⬆️
src/date-picker/panel/date-range.tsx 7.48% <0.00%> (+0.29%) ⬆️
src/dialog/props.ts 70.00% <0.00%> (-30.00%) ⬇️
src/hooks/useVirtualScroll.ts 24.51% <ø> (ø)
src/input/index.ts 100.00% <ø> (ø)
... and 128 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a8628a...f598235. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented May 10, 2022

完成

@github-actions
Copy link
Contributor

Size Change: +22 B (0%)

Total Size: 640 kB

Filename Size Change
./dist/tdesign.js 355 kB +13 B (0%)
./dist/tdesign.min.js 204 kB +9 B (0%)
ℹ️ View Unchanged
Filename Size
./dist/tdesign.css 43 kB
./dist/tdesign.min.css 38.2 kB

@uyarn uyarn force-pushed the fix/dialog-lock branch from ee1fa27 to f598235 Compare May 10, 2022 10:38
@github-actions
Copy link
Contributor

Size Change: +16 B (0%)

Total Size: 640 kB

Filename Size Change
./dist/tdesign.js 355 kB +9 B (0%)
./dist/tdesign.min.js 204 kB +7 B (0%)
ℹ️ View Unchanged
Filename Size
./dist/tdesign.css 43 kB
./dist/tdesign.min.css 38.2 kB

@xiaosansiji xiaosansiji merged commit 735463c into develop May 10, 2022
@xiaosansiji xiaosansiji deleted the fix/dialog-lock branch May 10, 2022 10:47
@github-actions github-actions bot mentioned this pull request May 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants