Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ts type #844

Merged
merged 1 commit into from
May 7, 2022
Merged

fix: ts type #844

merged 1 commit into from
May 7, 2022

Conversation

uyarn
Copy link
Collaborator

@uyarn uyarn commented May 7, 2022

🤔 这个 PR 的性质是?

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

📝 更新日志

  • fix(ConfigProvider): 修复animation属性excludeinclude在TS中都必填的问题

  • fix(Table): renderExpandedRow为非必填

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

@uyarn uyarn changed the title fix(ConfigProvider): animation type is partial fix(ConfigProvider): set animation type as partial May 7, 2022
@github-actions
Copy link
Contributor

github-actions bot commented May 7, 2022

Size Change: 0 B

Total Size: 640 kB

ℹ️ View Unchanged
Filename Size
./dist/tdesign.css 43 kB
./dist/tdesign.js 355 kB
./dist/tdesign.min.css 38.2 kB
./dist/tdesign.min.js 203 kB

@codecov-commenter
Copy link

codecov-commenter commented May 7, 2022

Codecov Report

Merging #844 (50bcd83) into develop (a0db0df) will increase coverage by 3.89%.
The diff coverage is 63.43%.

@@             Coverage Diff             @@
##           develop     #844      +/-   ##
===========================================
+ Coverage    57.56%   61.45%   +3.89%     
===========================================
  Files          346      355       +9     
  Lines        12828    13434     +606     
  Branches      2405     2547     +142     
===========================================
+ Hits          7384     8256     +872     
+ Misses        5200     4920     -280     
- Partials       244      258      +14     
Impacted Files Coverage Δ
src/avatar/group.tsx 97.14% <ø> (ø)
src/breadcrumb/breadcrumb-item-props.ts 100.00% <ø> (ø)
src/cascader/props.ts 91.66% <ø> (ø)
src/cascader/utils/inputContent.ts 59.45% <0.00%> (+6.68%) ⬆️
src/date-picker/date-picker.tsx 46.57% <0.00%> (+0.72%) ⬆️
src/date-picker/panel/date-range.tsx 7.48% <0.00%> (+0.29%) ⬆️
src/dialog/props.ts 70.00% <0.00%> (-30.00%) ⬇️
src/hooks/useVirtualScroll.ts 24.51% <ø> (ø)
src/input/index.ts 100.00% <ø> (ø)
src/menu/menu.tsx 61.90% <ø> (ø)
... and 129 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 723095e...50bcd83. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented May 7, 2022

完成

@github-actions
Copy link
Contributor

github-actions bot commented May 7, 2022

Size Change: 0 B

Total Size: 640 kB

ℹ️ View Unchanged
Filename Size
./dist/tdesign.css 43 kB
./dist/tdesign.js 355 kB
./dist/tdesign.min.css 38.2 kB
./dist/tdesign.min.js 203 kB

@uyarn uyarn changed the title fix(ConfigProvider): set animation type as partial fix: ts type May 7, 2022
@github-actions
Copy link
Contributor

github-actions bot commented May 7, 2022

Size Change: 0 B

Total Size: 640 kB

ℹ️ View Unchanged
Filename Size
./dist/tdesign.css 43 kB
./dist/tdesign.js 355 kB
./dist/tdesign.min.css 38.2 kB
./dist/tdesign.min.js 203 kB

@xiaosansiji xiaosansiji merged commit 0375b77 into develop May 7, 2022
@xiaosansiji xiaosansiji deleted the fix/ts-type branch May 7, 2022 06:23
@xiaosansiji xiaosansiji mentioned this pull request May 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants