Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(tree): tree 组件实现嵌套结构渲染能力 #740

Merged
merged 19 commits into from
Apr 22, 2022

Conversation

TabSpace
Copy link
Collaborator

🤔 这个 PR 的性质是?

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • ☑️ 演示代码改进
  • ☑️ 组件样式/交互改进
  • CI/CD 改进
  • ☑️ 重构
  • 代码风格优化
  • ☑️ 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

期望兼容嵌套布局呈现,以便于未来增强无虚拟滚动情形下的动画性能

💡 需求背景和解决方案

  1. 计划实现嵌套布局切换能力,为来来进一步提升性能做准备
  2. 发现外部一些变化,如 filter 启用时,input onchange 会触发所有子节点 render,对此进行解决

📝 更新日志

  • refactor(tree): tree 组件实现嵌套结构渲染能力
  1. 实现了嵌套布局切换能力,该能力暂未对用户开放,未来还需要进一步减少子节点刷新次数来提升该布局下的动画性能。
  2. 部分属性改为不让 vue 监听,一定程度上提升组件性能,减少对外部组件交互性能的影响。
  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • ☑️ 文档已补充或无须补充
  • ☑️ 代码演示已提供或无须提供
  • ☑️ TypeScript 定义已补充或无须补充
  • ☑️ Changelog 已提供或无须提供

@github-actions
Copy link
Contributor

github-actions bot commented Apr 14, 2022

完成

@codecov-commenter
Copy link

codecov-commenter commented Apr 15, 2022

Codecov Report

Merging #740 (4f87847) into develop (a0db0df) will increase coverage by 4.04%.
The diff coverage is 66.79%.

@@             Coverage Diff             @@
##           develop     #740      +/-   ##
===========================================
+ Coverage    57.56%   61.60%   +4.04%     
===========================================
  Files          346      354       +8     
  Lines        12828    13260     +432     
  Branches      2405     2500      +95     
===========================================
+ Hits          7384     8169     +785     
+ Misses        5200     4837     -363     
- Partials       244      254      +10     
Impacted Files Coverage Δ
src/avatar/group.tsx 97.14% <ø> (ø)
src/breadcrumb/breadcrumb-item-props.ts 100.00% <ø> (ø)
src/cascader/props.ts 91.66% <ø> (ø)
src/cascader/utils/inputContent.ts 59.45% <0.00%> (+6.68%) ⬆️
src/date-picker/date-picker.tsx 46.57% <0.00%> (+0.72%) ⬆️
src/dialog/props.ts 70.00% <0.00%> (-30.00%) ⬇️
src/hooks/useVirtualScroll.ts 24.51% <ø> (ø)
src/input/index.ts 100.00% <ø> (ø)
src/menu/menu.tsx 61.90% <ø> (ø)
src/select/select.tsx 41.76% <ø> (ø)
... and 122 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a10adc7...4f87847. Read the comment docs.

@chaishi chaishi merged commit 45d73cf into Tencent:develop Apr 22, 2022
@github-actions github-actions bot mentioned this pull request Apr 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants