Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Select & TimePicker 小优化 #344

Merged
merged 2 commits into from
Jan 26, 2022
Merged

feat: Select & TimePicker 小优化 #344

merged 2 commits into from
Jan 26, 2022

Conversation

ikeq
Copy link
Contributor

@ikeq ikeq commented Jan 25, 2022 •
edited
Loading

  • Select：优化 options 的初始化解析，pr 344，@ikeq
  • TimePicker：优化 panel 定位时机，pr 344，@ikeq

brefore
select: options 提取完全依赖 children 挂载

after

  • select: 在 children 挂载前做一次 options 的提取
  • time-picker：提升一点健壮性

PS: 此 PR 应不会对组件目前的行为产生任何影响，是配合 Popup 组件做改动

@github-actions
Copy link
Contributor

github-actions bot commented Jan 25, 2022 •
edited
Loading

完成

geff1991
geff1991 approved these changes Jan 25, 2022
View reviewed changes
Copy link
Contributor

@geff1991 geff1991 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ikeq ikeq changed the title Ikeq patch 1 feat: Select & TimePicker 小优化 Jan 25, 2022
@chaishi chaishi merged commit bfe9fc6 into Tencent:develop Jan 26, 2022
@ikeq ikeq deleted the ikeq-patch-1 branch January 26, 2022 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geff1991 geff1991 geff1991 approved these changes

@chaishi chaishi chaishi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ikeq @geff1991 @chaishi