Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Badge): 修复徽标错误行为 #2206

Merged
merged 1 commit into from
Mar 7, 2023
Merged

Conversation

liect
Copy link
Contributor

@liect liect commented Mar 3, 2023

🤔 这个 PR 的性质是?

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

💡 需求背景和解决方案

📝 更新日志

  • fix(Badge): 修复徽标错误行为

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

@github-actions
Copy link
Contributor

github-actions bot commented Mar 3, 2023

完成

@liect
Copy link
Contributor Author

liect commented Mar 3, 2023

这个测试我很迷茫,为什么结果有时候有错误,有时候全PASS,错误有时还不一样,我系统的原因吗???
微信截图_20230303162234
微信截图_20230303162419

@uyarn
Copy link
Collaborator

uyarn commented Mar 6, 2023

这个测试我很迷茫,为什么结果有时候有错误,有时候全PASS,错误有时还不一样,我系统的原因吗??? 微信截图_20230303162234 微信截图_20230303162419

也许你不是node 18 guide这个snapshot确实在不同环境跑出来的确实不太一样 可以暂时不带上这个文件的diff

@liect
Copy link
Contributor Author

liect commented Mar 6, 2023

这个测试我很迷茫,为什么结果有时候有错误,有时候全PASS,错误有时还不一样,我系统的原因吗??? 微信截图_20230303162234 微信截图_20230303162419

也许你不是node 18 guide这个snapshot确实在不同环境跑出来的确实不太一样 可以暂时不带上这个文件的diff

那我就不更新快照了,直接提交修改吧,这次修改我看测试文件,并不需要重新生成快照,快照diff也没有badge的相关更改,看起来都是common库更改引起的更新
微信截图_20230306143323

@uyarn uyarn merged commit a6937b3 into Tencent:develop Mar 7, 2023
@github-actions github-actions bot mentioned this pull request Mar 9, 2023
@liect liect deleted the fix/badge branch March 15, 2023 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants