Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dialog、Loading]关闭销毁初始化css 和 修复loading全屏实例无法全部销毁问题 #1774

Merged
merged 10 commits into from
Nov 11, 2022

Conversation

huangpiqiao
Copy link
Contributor

@huangpiqiao huangpiqiao commented Nov 11, 2022

🤔 这个 PR 的性质是?

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

💡 需求背景和解决方案

Dialog: PR#1766的补充
Loading:
问题:LoadingPlugin(true)多次创建时,无法通过LoadingPlugin(false)只能销毁一层
解决方案:当全局实例存在时先销毁再创建

📝 更新日志

  • [fix] 修复LoadingPlugin(true)可以创建多个loading全屏实例且无法通过LoadingPlugin(false)全部销毁的问题

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

@github-actions
Copy link
Contributor

github-actions bot commented Nov 11, 2022

失败

@huangpiqiao huangpiqiao changed the title [Dialog]关闭销毁初始化css [Dialog、Loading]关闭销毁初始化css 和 修复loading全屏实例无法全部销毁问题 Nov 11, 2022
@uyarn
Copy link
Collaborator

uyarn commented Nov 11, 2022

CI失败的影响因素已经修复了 这里合并掉

@uyarn uyarn merged commit 20d7ee9 into Tencent:develop Nov 11, 2022
@github-actions github-actions bot mentioned this pull request Nov 11, 2022
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants