fix(select): 修复过滤掉数据后上下键仍可以选择过滤外的数据问题 #1434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 这个 PR 的性质是？
🔗 相关 Issue
#1433
💡 需求背景和解决方案
keydownEvent()的数据来源是useSelectOption的optionsList，而不是filter之后的displayOptions，所以会出现可以选择过滤之外的数据的问题。
为了能使上下键移动时正确触发hover，需要单独处理一下displayOptions里的index属性，使其根据过滤后的数组大小依次递增，而不是在useSelectOption里处理的值。
📝 更新日志
fix(select): 修复过滤掉数据后上下键仍可以选择过滤外的数据问题
本条 PR 不需要纳入 Changelog
☑️ 请求合并前的自查清单