Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 修复 suffixIcon slot 写法失效问题 #1280

Merged
merged 3 commits into from
Aug 16, 2022

Conversation

honkinglin
Copy link
Collaborator

@honkinglin honkinglin commented Aug 12, 2022

🤔 这个 PR 的性质是?

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

💡 需求背景和解决方案

📝 更新日志

  • fix(DatePicker): 修复 suffixIcon slot 写法失效问题

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

@honkinglin honkinglin linked an issue Aug 12, 2022 that may be closed by this pull request
@honkinglin honkinglin changed the title fix: 修复 suffixIcon slot 写法错误 fix: 修复 suffixIcon slot 写法失效问题 Aug 12, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Aug 12, 2022

完成

@codecov-commenter
Copy link

Codecov Report

Merging #1280 (3bd7528) into develop (492d477) will increase coverage by 0.03%.
The diff coverage is 40.61%.

@@             Coverage Diff             @@
##           develop    #1280      +/-   ##
===========================================
+ Coverage    57.94%   57.98%   +0.03%     
===========================================
  Files          407      408       +1     
  Lines        15371    15302      -69     
  Branches      2931     2907      -24     
===========================================
- Hits          8907     8873      -34     
+ Misses        6187     6153      -34     
+ Partials       277      276       -1     
Impacted Files Coverage Δ
src/cascader/cascader.tsx 64.00% <ø> (ø)
src/color-picker/color-picker.tsx 81.25% <ø> (ø)
src/date-picker/base/Header.tsx 7.57% <0.00%> (-0.37%) ⬇️
src/date-picker/date-picker-panel-props.ts 100.00% <ø> (+90.00%) ⬆️
src/date-picker/date-range-picker-panel-props.ts 100.00% <ø> (+90.90%) ⬆️
src/date-picker/date-range-picker-props.ts 42.85% <0.00%> (-11.69%) ⬇️
src/date-picker/hooks/useRange.ts 35.89% <ø> (ø)
src/date-picker/hooks/useSingle.ts 37.28% <ø> (ø)
src/date-picker/hooks/useTableData.ts 17.64% <ø> (ø)
src/date-picker/panel/RangePanel.tsx 36.36% <ø> (ø)
... and 148 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@xiaosansiji xiaosansiji merged commit bc3adfc into develop Aug 16, 2022
@xiaosansiji xiaosansiji deleted the fix/datepicker/slot-suffix-icon branch August 16, 2022 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Datepicker] 自定义图标功能 prefixIcon, suffixIcon 不生效
3 participants