Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(radio): add support for allowUncheck #123

Merged
merged 5 commits into from
Dec 29, 2021

Conversation

start940315
Copy link
Contributor

  • radio:新增对allowUncheck属性的支持

@github-actions
Copy link
Contributor

github-actions bot commented Dec 28, 2021

PR 预览产物在 https://preview-pr123-tdesign-vue.surge.sh

}
if (!this.checked || !this.allowUncheck) return;
if (this.radioGroup) {
this.radioGroup.$emit('checked-change', null, { e });
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

null 更为 undefined

@@ -78,5 +79,16 @@ export default (Vue as VueConstructor<RadioInstance>).extend({
emitEvent<Parameters<TdRadioProps['onChange']>>(this, 'change', target.checked, { e });
}
},
handleClick(e: Event) {
if (typeof this.$listeners.click === 'function') {
this.$listeners.click(e);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this.$listeners.click(e)
此处直接写成 this.$emit('click')

@chaishi chaishi merged commit 73493cf into Tencent:develop Dec 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants