Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: select empty slot render #1214

Merged
merged 1 commit into from
Jul 26, 2022
Merged

fix: select empty slot render #1214

merged 1 commit into from
Jul 26, 2022

Conversation

xiaosansiji
Copy link
Collaborator

@xiaosansiji xiaosansiji commented Jul 26, 2022

🤔 这个 PR 的性质是?

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

#1212

💡 需求背景和解决方案

image

image

原有实现只处理了 props 的用法

📝 更新日志

  • fix(Select): 修复 empty slot 用法不生效的问题

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

@codecov-commenter
Copy link

Codecov Report

Merging #1214 (743063d) into develop (aaf0135) will decrease coverage by 0.26%.
The diff coverage is 21.19%.

@@             Coverage Diff             @@
##           develop    #1214      +/-   ##
===========================================
- Coverage    58.80%   58.53%   -0.27%     
===========================================
  Files          405      406       +1     
  Lines        15051    15149      +98     
  Branches      2844     2866      +22     
===========================================
+ Hits          8851     8868      +17     
- Misses        5927     6008      +81     
  Partials       273      273              
Impacted Files Coverage Δ
src/date-picker/DateRangePicker.tsx 15.28% <0.00%> (-0.51%) ⬇️
src/date-picker/hooks/useRange.ts 36.58% <0.00%> (+0.44%) ⬆️
src/date-picker/hooks/useSingle.ts 37.28% <0.00%> (-2.00%) ⬇️
src/date-picker/panel/PanelContent.tsx 36.36% <ø> (ø)
src/table/base-table-props.ts 61.53% <ø> (ø)
src/table/base-table.tsx 79.52% <ø> (ø)
src/table/editable-cell.tsx 7.03% <0.00%> (-2.41%) ⬇️
src/table/hooks/tree-store.ts 10.39% <ø> (ø)
src/table/hooks/useClassName.ts 100.00% <ø> (ø)
src/time-picker/panel/single-panel.tsx 8.78% <10.00%> (-0.06%) ⬇️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 540f88d...743063d. Read the comment docs.

@github-actions
Copy link
Contributor

完成

@uyarn uyarn merged commit 72d491b into develop Jul 26, 2022
@uyarn uyarn deleted the fix/select-empty branch July 26, 2022 06:12
This was referenced Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants