Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: useconfig cloneDeep #1024

Merged
merged 4 commits into from
Jun 17, 2022
Merged

fix: useconfig cloneDeep #1024

merged 4 commits into from
Jun 17, 2022

Conversation

PengYYYYY
Copy link
Collaborator

🤔 这个 PR 的性质是?

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

💡 需求背景和解决方案

📝 更新日志

  • fix(ConfigProvider): 修复 useConfig 的意外注册
  • fix(ConfigProvider): 修复因为深拷贝配置文件导致的性能问题

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

@github-actions
Copy link
Contributor

github-actions bot commented Jun 16, 2022

完成

@codecov-commenter
Copy link

codecov-commenter commented Jun 16, 2022

Codecov Report

Merging #1024 (cd44016) into develop (a0db0df) will increase coverage by 2.10%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #1024      +/-   ##
===========================================
+ Coverage    57.56%   59.67%   +2.10%     
===========================================
  Files          346      383      +37     
  Lines        12828    14652    +1824     
  Branches      2405     2748     +343     
===========================================
+ Hits          7384     8743    +1359     
- Misses        5200     5642     +442     
- Partials       244      267      +23     
Impacted Files Coverage Δ
src/affix/affix.tsx 28.57% <0.00%> (-37.51%) ⬇️
src/swiper/props.ts 68.75% <0.00%> (-31.25%) ⬇️
src/dialog/props.ts 70.00% <0.00%> (-30.00%) ⬇️
src/calendar/props.ts 70.00% <0.00%> (-30.00%) ⬇️
src/popup/props.ts 75.00% <0.00%> (-25.00%) ⬇️
src/select/props.ts 75.00% <0.00%> (-25.00%) ⬇️
src/slider/props.ts 75.00% <0.00%> (-25.00%) ⬇️
src/message/props.ts 75.00% <0.00%> (-25.00%) ⬇️
src/tooltip/props.ts 75.00% <0.00%> (-25.00%) ⬇️
src/pagination/props.ts 75.00% <0.00%> (-25.00%) ⬇️
... and 165 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45d9e30...cd44016. Read the comment docs.

src/config-provider/config-provider.tsx Outdated Show resolved Hide resolved
src/hooks/useConfig.ts Outdated Show resolved Hide resolved
Copy link
Collaborator

@uyarn uyarn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@uyarn uyarn merged commit c151415 into develop Jun 17, 2022
@uyarn uyarn deleted the fix/useconfig/cloneDeep branch June 17, 2022 07:03
@github-actions github-actions bot mentioned this pull request Jun 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants