Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(t-head-menu): t-submenu template #icon not work #643

Merged
merged 1 commit into from
May 6, 2022

Conversation

fengxianqi
Copy link
Contributor

@fengxianqi fengxianqi commented Apr 23, 2022

🤔 这个 PR 的性质是?

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

#510

💡 需求背景和解决方案

📝 更新日志

  • fix(menu): 使用t-submenu template #icon无效的问题

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

@codecov-commenter
Copy link

codecov-commenter commented Apr 23, 2022

Codecov Report

❗ No coverage uploaded for pull request base (develop@2057cac). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             develop     #643   +/-   ##
==========================================
  Coverage           ?   60.93%           
==========================================
  Files              ?      402           
  Lines              ?    13869           
  Branches           ?     2596           
==========================================
  Hits               ?     8451           
  Misses             ?     5180           
  Partials           ?      238           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2057cac...faaa9ea. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 23, 2022

完成

src/menu/submenu.tsx Outdated Show resolved Hide resolved
src/menu/submenu.tsx Outdated Show resolved Hide resolved
@PengYYYYY
Copy link
Collaborator

能否先处理fix(t-head-menu): 使用t-submenu template #icon无效的问题

@fengxianqi fengxianqi force-pushed the fix/t-submenu-icon branch from faaa9ea to ef11596 Compare May 5, 2022 06:50
@fengxianqi
Copy link
Contributor Author

已update为只修复一个问题 @PengYYYYY

@PengYYYYY
Copy link
Collaborator

处理一下冲突,这个PR应该不需要更新common的

@PengYYYYY PengYYYYY force-pushed the fix/t-submenu-icon branch from ef11596 to 573f707 Compare May 6, 2022 05:27
@PengYYYYY PengYYYYY merged commit 1ebbcce into Tencent:develop May 6, 2022
@github-actions github-actions bot mentioned this pull request May 6, 2022
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants