Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(tooltip): rewrite tooltip with composition api #566

Merged
merged 4 commits into from
Apr 23, 2022

Conversation

cca313
Copy link
Contributor

@cca313 cca313 commented Apr 10, 2022

🤔 这个 PR 的性质是?

  • 重构

🔗 相关 Issue

composition api重构

💡 需求背景和解决方案

📝 更新日志

  • refactor(tooltip): 使用compositionAPI重构tooltip组件

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

@PengYYYYY
Copy link
Collaborator

把mapprops 去掉一下

@PengYYYYY
Copy link
Collaborator

PengYYYYY commented Apr 11, 2022

index.ts 里面,可以参考下面文档

@PengYYYYY PengYYYYY mentioned this pull request Apr 11, 2022
52 tasks
@94dreamer 94dreamer closed this Apr 11, 2022
@94dreamer 94dreamer reopened this Apr 11, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Apr 11, 2022

完成

@cca313 cca313 force-pushed the refactor/tooltip branch from 6b4df77 to 8a7de2a Compare April 19, 2022 10:45
@PengYYYYY PengYYYYY force-pushed the compositionAPI branch 2 times, most recently from 23cb201 to 5a92b0e Compare April 22, 2022 16:15
Copy link
Collaborator

@PengYYYYY PengYYYYY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不要改popup喔

@cca313
Copy link
Contributor Author

cca313 commented Apr 23, 2022

不要改popup喔

就是不敢乱改才请求支援的

@PengYYYYY
Copy link
Collaborator

不要改popup喔

就是不敢乱改才请求支援的

602ea23 这个commit我处理好了

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (compositionAPI@5a92b0e). Click here to learn what that means.
The diff coverage is n/a.

@@                Coverage Diff                @@
##             compositionAPI     #566   +/-   ##
=================================================
  Coverage                  ?   64.35%           
=================================================
  Files                     ?      393           
  Lines                     ?    13717           
  Branches                  ?     2566           
=================================================
  Hits                      ?     8828           
  Misses                    ?     4640           
  Partials                  ?      249           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a92b0e...ce2e824. Read the comment docs.

@PengYYYYY PengYYYYY merged commit ca4012e into Tencent:compositionAPI Apr 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants